1882600 - Tab-to-search should handle search sub-domains

Status: NEW

(Firefox :: Address Bar, enhancement, P2)

Description

[Mike Kaply [:mkaply]]

Right now the search nudge it set to two characters and it disappears at three.

We'd like to see if this can be extended (or maybe even be partner specific).

We're working with a partner (seznam), and sez is a much better signal

In addition, it seems like we should be looking at the whole word.

IF they type "seznam" or "google" it should be a signal.

With only two letter, if a user types fast, they won't see the nudge.

Comment 1

[Mark Banner (:standard8)]

The main problem here is that Seznam's search url is https://search.seznam.cz/. Tab-to-search is matching on the full domain, so typing se matches the start, but sez does not match search. If I type sea then I still see the nudge.

We should investigate ignoring the sub-domain if it is search, like we do for en. in other cases.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bug 1882600 - Use the base domain for search nudge. r?adw

Comment 3

[Mike Kaply [:mkaply]]

Taking of my plate. We should fix, but I don't have the bandwidth right now.