1882622 - Fix the crash on test_ext_browserSettings_overrideDocumentColors.html or disable the test on Android

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

As per bug 1877892 comment 8, this test always fails on Android. And more seriously any subsequent tests in the same job haven't been run properly. That means we've lost some amount of test coverage there.

Rob or Luca, can either of you guys take a look at this test? Thanks!

Comment 1

[Rob Wu [:robwu]]

I described the reason for the failure and how the test helper can be fixed, in bug 1876317.

The reason for not having fixed this already is that the architectural issue extends beyond tests, as seen in bug 1876329.

If this failure is causing lots of trouble, I'm willing to sign off on skipping the test on Android, with a reference to 1876317.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Great to hear that! I will post a patch to disable the test. Thanks!

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1882622 - Disable test_ext_browserSettings_overrideDocumentColors.html on Android. r?robwu

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4db9e75826d8
Disable test_ext_browserSettings_overrideDocumentColors.html on Android. r=robwu

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4db9e75826d8