188264 - migrating user activity from one account to another (merge user accounts)

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Myk Melez [:myk] [@mykmelez]]

In rare cases it may be useful to migrate user activity from one account to
another.  A script for doing this would be useful.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: script to do the job

This script does the job with a caveat: updates that attempt to insert
duplicate keys into tables will fail.

Comment 2

[Dave Miller [:justdave]]

Is this anything like bug 112317?

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Almost, except I think in this case the two accounts should remain independent;
just the activity should be migrated.  Bug 112317 calls for one account to cease
to exist afterwards.  On the other hand, maybe this is what should happen in
this case too.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

I was assuming my old account would cease to exist afterwards.  Seems like it
ought to so that people can't inadvertantly CC or assign to it.

Comment 5

[Bradley Baetz (:bbaetz)]

I don't like this sort of stuff as a matter of principle. Does it really matter
that you hve two accounts?

You need to delete from teh profiles table, too.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Attachment: script v2: deletes accounts, deals with duplicate key failures

Comment 7

[Dave Miller [:justdave]]

*** Bug 112317 has been marked as a duplicate of this bug. ***

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Attachment: script v3: bug fixes

This version correctly merges all user_group_map records.  I call this script
merge-users.pl and run it from the Bugzilla root directory.  Note that it works
with the schema in effect on Tue Nov 19 01:12:48 PST 2002, which may or may not
be the same one on the trunk.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Notes:

1. I ran this script on b.m.o about 15 minutes ago as "./merge-users.pl
[e-mail] [e-mail]".

2. If Bugzilla is shut down the script erroneously reports that it can't find
the old user (i.e. the first one in the list, whose profiles table settings are
deleted in preference to the "new" user, or the second one in the list).

Comment 10

[Jacob Steenhagen]

That's because if Bugzilla is shut down, SendSQL won't send quieries to the
database unless they are coming from editparams.cgi

Comment 11

[Dave Miller [:justdave]]

We should tidy this up and work it into editusers.cgi

Comment 12

[Dave Miller [:justdave]]

Attachment: script v4: updated for 2.19.2 schema

I've updated the script to work with the 2.19.2 schema and database API.  I
guarantee you that it won't work in 2.19.3 because there's been yet more schema
and API changes.  Changes in this version from the previous include migrating
chart series, and the changes in the definition to the user_group_map table.

Comment 13

[Dave Miller [:justdave]]

Reassigning bugs that I'm not actively working on to the default component owner
in order to try to make some sanity out of my personal buglist.  This doesn't
mean the bug isn't being dealt with, just that I'm not the one doing it.  If you
are dealing with this bug, please assign it to yourself.

Comment 14

[Dave Miller [:justdave]]

This is still mine.

Comment 15

[Frédéric Buclin]

The trunk is now frozen to prepare Bugzilla 2.22. Enhancement bugs are retargetted to 2.24.

Comment 16

[Dave Miller [:justdave]]

*** Bug 317902 has been marked as a duplicate of this bug. ***

Comment 17

[Frédéric Buclin]

Attachment: merge-users.pl compatible with 2.20+

Comment 18

[Frédéric Buclin]

Attachment: merge-users.pl compatible with 2.20+, v2

slight improvement:

don't go further if both accounts are identical.

Comment 19

[Max Kanat-Alexander]

Comment on attachment 207388 [details]
merge-users.pl compatible with 2.20+, v2

  I think the script should print out its usage instead of having it in the comments.

># We require Bugzilla 2.20 - 2.20.x.
>my $expected_version = "2.20";
>my $current_version = $Bugzilla::Config::VERSION;
>if ($current_version =~ /^\Q$expected_version\E/) {
>    print "OK, you are using Bugzilla $current_version\n"
>}
>else {
>    die "You are using Bugzilla $current_version but Bugzilla " .
>        "$expected_version.x is required.\n";
>}

  I don't think that this is really necessary. At the least, it's just going to be a pain to keep it updated on various branches in the future.

># Make sure the old and new accounts are different.
>if ($old_id = $new_id) {
>    die "\nBoth accounts are identical. There is nothing to migrate.\n";
>}

  That should be "==" I believe.

># A list of tables and columns to be changed:
># - keys of the hash are table names to be locked/altered;
># - values of the hash are arrays of column lists to be updated:
>#   = the first name of the list is the column to update,
>#   = the remaining names are the columns to check to avoid duplicated entries.

  I think you should explain what you mean by "first name of the list" and "remaining names of the list." I remember that you had to explain to me how the script actually works; I didn't fully understand it just from the comments.

>        # Will be used to migrate the old user account to the new one.
>        my $sth_Update = $dbh->prepare("UPDATE $table

  Nit: Having that "Update" be capitalized violates perlstyle. Same for the "Delete" one later.

  Everything else looks fine. I know that this works since we used it for a client.

Comment 20

[Frédéric Buclin]

Attachment: merge-users.pl compatible with 2.20+, v3

Fixes all comments, except the version check as discussed on IRC.

Comment 21

[Max Kanat-Alexander]

Comment on attachment 208157 [details]
merge-users.pl compatible with 2.20+, v3

Okay, I know that this works on 2.20. Could you also post a version for 2.22 and the tip?

Comment 22

[Max Kanat-Alexander]

This is just a contrib script, and I *know* it works on the branch, so I don't see any reason not to check it in to the branches.

Comment 23

[Frédéric Buclin]

AFAIK, the schema didn't change between 2.20 and 2.22 (and even 2.23 so far) about userid. And my patch already accepts 2.22 as a valid Bugzilla version. I can make it accept 2.23 as well on checkin.

Comment 24

[Dave Miller [:justdave]]

hell yes. :)

Comment 25

[Frédéric Buclin]

tip:

Checking in contrib/merge-users.pl;
/cvsroot/mozilla/webtools/bugzilla/contrib/merge-users.pl,v  <--  merge-users.pl
initial revision: 1.1
done

2.22rc1:

Checking in contrib/merge-users.pl;
/cvsroot/mozilla/webtools/bugzilla/contrib/merge-users.pl,v  <--  merge-users.pl
new revision: 1.1.2.2; previous revision: 1.1.2.1
done

2.20.1:

Checking in contrib/merge-users.pl;
/cvsroot/mozilla/webtools/bugzilla/contrib/merge-users.pl,v  <--  merge-users.pl
new revision: 1.1.4.2; previous revision: 1.1.4.1
done