1882669 - Building without MOZ_PLACES or MOZ_ANDROID_HISTORY fails

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Mike Hommey [:glandium]]

STR:

• Remove imply_option("MOZ_PLACES", True) from browser/moz.configure
• build

The failure looks like:

docshell/base/nsDocShell.cpp:12275:53: error: no member named 'Service' in 'mozilla::IHistory'
 12275 |   nsCOMPtr<IHistory> history = components::History::Service();
       |                                ~~~~~~~~~~~~~~~~~~~~~^

It's fine, as it's not the kind of thing that one should stumble upon... except when they are setting up a new toolkit-based application.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1882669 - Enforce that one of MOZ_ANDROID_HISTORY or MOZ_PLACES must be set.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6d962cdaea6
Enforce that one of MOZ_ANDROID_HISTORY or MOZ_PLACES must be set. r=mak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b5cfec92393
Fix debug build bustages. CLOSED TREE

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b6d962cdaea6
https://hg.mozilla.org/mozilla-central/rev/4b5cfec92393