Closed Bug 1882670 Opened 1 years ago Closed 1 year ago

iframe with loading="lazy" is not loading when src is set with location.replace

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED
132 Branch
Webcompat Priority P2
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- wontfix
firefox123 --- wontfix
firefox124 + wontfix
firefox125 + wontfix
firefox126 + wontfix
firefox130 --- wontfix
firefox131 --- wontfix
firefox132 --- fixed

People

(Reporter: ksenia, Assigned: sefeng211)

References

(Blocks 1 open bug, Regression, )

Details

(Keywords: regression, webcompat:platform-bug)

Attachments

(2 files)

We've got a report in https://github.com/webcompat/web-bugs/issues/132888 where an iframe with loading="lazy" attribute doesn't load.

To reproduce, visit https://reneweconomy.com.au/nem-watch/ and observe the page.

The site appears to be using e.contentWindow.location.replace() with a url from the data-src attribute:

            de = function (e, t) {
              var n = e.getAttribute('data-load-mode') ||
              a.iframeLoadMode;
              0 == n ? e.contentWindow.location.replace(t) : 1 == n &&
              (e.src = t)
            },

mozregression:

29:20.39 INFO: Last good revision: a799334876042dd316b1f327a7421e3dbaec7570
29:20.39 INFO: First bad revision: 13cc0076698685511e3fa7c0fa91b02675ff5baa
29:20.39 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a799334876042dd316b1f327a7421e3dbaec7570&tochange=13cc0076698685511e3fa7c0fa91b02675ff5baa
Attached file 132888.html

Attached a reduced test case

Hi Oliver, wonder if you could take a look at this, please?

Flags: needinfo?(omedhurst)

Set release status flags based on info from the regressing bug 1622090

:hsinyi do you think you can provide priority/severity for triage purposes?

Flags: needinfo?(htsai)
Severity: -- → S3
Flags: needinfo?(htsai)
Priority: -- → P2

Video embeds (youtube and facebook) fail to load on scheerpost.com with the same regression window (Bug 1622090) which also store the url in the data-src attribute. Works with dom.iframe_lazy_loading.enabled = false. Example:

https://scheerpost.com/2024/03/11/the-oppenheimer-package-the-story-of-soviet-spy-ted-hall-and-daniel-ellsberg-on-the-dangers-of-nuclear-war/

Webcompat Priority: --- → ?

Both sites appear to be using lazysizes library, which is quite popular.

(relevant code chunk is https://github.com/aFarkas/lazysizes/blob/gh-pages/src/lazysizes-core.js#L484)

Simon, do we have an easy way to figure out if the library that Ksenia mentioned is used on a lot of popular sites?

Webcompat Priority: ? → P2
Flags: needinfo?(zcorpan)

Actually, let's keep this as a webcompat-priority=P1 unless we have evidence to suggest it's not a big issue.

[Tracking Requested - why for this release]: This is breaking a potentially popular way of lazy-loading social media embeds on an unknown number of sites. Also, it's a regression.

Webcompat Priority: P2 → P1

The severity field for this bug is set to S3. However, this bug has a P1 WebCompat priority.
:mccr8, could you consider increasing the severity of this web compatibility bug?

For more information, please visit BugBot documentation.

Flags: needinfo?(continuation)

Set release status flags based on info from the regressing bug 1622090

Severity: S3 → S2
Flags: needinfo?(continuation)

I'll bump up the severity then.

I tested a bit in http://software.hixie.ch/utilities/js/live-dom-viewer/saved/12473 (based on the attached test case) and here's what I think happens:

The script runs before layout is known, and navigates the iframe with location.replace. Then, the lazy-loading mechanism determines that the iframe is in view, and loads the URL in src.

However, I also get this result in Safari TP (but not in Chrome). If the sites aren't broken in Safari, then maybe there's a race condition about when the script runs vs when lazy-loading starts.

This behavior is per spec, I believe. Navigating by setting location.replace doesn't change the src attribute, and doesn't nullify the lazy loading "plans". (The spec handles updates to the src attribute, though, which is tested here). I'll file a spec bug and try to get clarify on what happens in Chromium.

I think it should be possible to check will lazy load element steps in the navigation algorithm, and if true set the iframe's lazy load resumption steps to null.

Keeping NI for httparchive analysis.

OK I have results from httparchive.

Out of 11,278,044 pages, 5510 distinct pages (0.05%) have:

  • lazySizes
  • triggers Chromium's LazyLoadFrameLoadingAttributeLazy use counter during page load
  • has one or more iframe elements with all of: src, data-src, class="lazyload" and loading="lazy"

These are only root pages, since the deep pages available in all don't have response bodies.

Those pages, ordered by rank magnitude, and the matching markup snippets, are available here:

https://docs.google.com/spreadsheets/d/11J_QoPcXhwO2irJ6hxr4n5dM5UadLH5vhhzUl_IrOY0/edit?usp=sharing

For manual analysis, search for iframe[loading=lazy]:is(.lazyload, .lazyloaded) in devtools to find the relevant iframe elements.

Looking at e.g. https://youngoia.com/ it appears that the iframe (map in the footer) loads OK if I scroll to it, but if I reload the page while scrolled down (so scroll position is restored), and "Disable Cache" is not checked, then this bug is reproduced.

Flags: needinfo?(zcorpan)

The bug is marked as tracked for firefox125 (beta) and tracked for firefox126 (nightly). However, the bug still isn't assigned.

:hsinyi, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Flags: needinfo?(htsai)

Resolving this issue depends on the resolution of https://github.com/whatwg/html/issues/10213

Flags: needinfo?(htsai)

This is a reminder regarding comment #14!

The bug is marked as tracked for firefox125 (beta) and tracked for firefox126 (nightly). We have limited time to fix this, the soft freeze is in 14 days. However, the bug still isn't assigned.

Doesn't seem likely that we'll be able to fix this for 125 if it's waiting on a spec change first, but I'd still consider taking a fix for this in a dot release if we have cross-browser consensus and the patch is simple enough.

This is a reminder regarding comment #14!

The bug is marked as tracked for firefox126 (nightly). We have limited time to fix this, the soft freeze is in 8 days. However, the bug still isn't assigned.

I'll be bold and set v126 to fix-optional, too. This is still the only WebCompat regression we found for the change, so this doesn't strike me as a high-priority thing. I'd immediately change my opinion if we discover more breakage, but that doesn't seem to be the case for now.

Webcompat Priority: P1 → P2

Verified this issue and still reproduces on Firefox Nightly. The [attached file]https://bugzilla.mozilla.org/attachment.cgi?id=9388282) loads significantly slower in Firefox, sometimes does not load at all

Tested with:

Browser / Version: Firefox Nightly 128.0a1 (2024-05-28) (64-bit)
Operating System: Windows 10 PRO x64

Oliver, assigning this to you, thanks.

Assignee: nobody → omedhurst
Flags: needinfo?(omedhurst)
Assignee: omedhurst → nobody
Attachment #9416919 - Attachment description: WIP: Bug 1882670 - Cancel the loading=lazy iframe when it's load → WIP: Bug 1882670 - Cancel the loading=lazy iframe when it's load via a different way r=#dom-core,emilio
Assignee: nobody → sefeng
Attachment #9416919 - Attachment description: WIP: Bug 1882670 - Cancel the loading=lazy iframe when it's load via a different way r=#dom-core,emilio → Bug 1882670 - Cancel the loading=lazy iframe when it's load via a different way r=#dom-core,emilio
Status: NEW → ASSIGNED
Pushed by sefeng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/437beb1efdd2 Cancel the loading=lazy iframe when it's load via a different way r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47516 for changes under testing/web-platform/tests

Backed out for causing wpt failures related on iframe-loading-lazy-nav-meta-refresh.optional.html

[task 2024-08-07T21:20:59.629Z] 21:20:59     INFO - TEST-START | /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-nav-meta-refresh.optional.html
[task 2024-08-07T21:20:59.653Z] 21:20:59     INFO - Closing window 997cc888-2e33-49d2-835d-acd20eb5a947
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL - Uncaught exception in TestRunnerManager.run:
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL - Traceback (most recent call last):
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -   File "/builds/worker/workspace/build/venv/lib/python3.8/site-packages/mozlog/logtypes.py", line 135, in __call__
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -     return self.convert(value)
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -   File "/builds/worker/workspace/build/venv/lib/python3.8/site-packages/mozlog/logtypes.py", line 251, in convert
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -     return [self.item_type.convert(item) for item in data]
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -   File "/builds/worker/workspace/build/venv/lib/python3.8/site-packages/mozlog/logtypes.py", line 251, in <listcomp>
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -     return [self.item_type.convert(item) for item in data]
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -   File "/builds/worker/workspace/build/venv/lib/python3.8/site-packages/mozlog/logtypes.py", line 208, in convert
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -     raise ValueError
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL - ValueError
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL - 
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL - During handling of the above exception, another exception occurred:
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL - 
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL - Traceback (most recent call last):
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/testrunner.py", line 467, in run_loop
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -     new_state = self.wait_event()
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/testrunner.py", line 586, in wait_event
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -     return f(*data)
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/testrunner.py", line 795, in test_ended
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -     self.logger.test_status(test.id,
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -   File "/builds/worker/workspace/build/venv/lib/python3.8/site-packages/mozlog/logtypes.py", line 56, in inner
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -     data = converter.convert(*args, **kwargs)
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -   File "/builds/worker/workspace/build/venv/lib/python3.8/site-packages/mozlog/logtypes.py", line 100, in convert
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -     out_value = self.args[key](value)
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -   File "/builds/worker/workspace/build/venv/lib/python3.8/site-packages/mozlog/logtypes.py", line 137, in __call__
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL -     raise ValueError(
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL - ValueError: Failed to convert value ['CRASH'] of type list for field known_intermittent to type List
[task 2024-08-07T21:21:04.201Z] 21:21:04 CRITICAL - 
[task 2024-08-07T21:21:04.202Z] 21:21:04 CRITICAL - Tests left in the queue: :'/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-nav-window-open.html' and 208 others
[task 2024-08-07T21:21:04.564Z] 21:21:04     INFO - STDOUT: cleanup aborted: Unable to remount device
[task 2024-08-07T21:21:04.658Z] 21:21:04     INFO - STDOUT: cleanup aborted: Unable to remount device
[task 2024-08-07T21:21:04.659Z] 21:21:04     INFO - Closing logging queue
[task 2024-08-07T21:21:04.659Z] 21:21:04     INFO - queue closed
[task 2024-08-07T21:21:04.764Z] 21:21:04     INFO - STDOUT: cleanup aborted: Unable to remount device
[task 2024-08-07T21:21:04.765Z] 21:21:04     INFO - STDERR: Exception in thread 
[task 2024-08-07T21:21:04.765Z] 21:21:04     INFO - STDERR: TestRunnerManager-0
[task 2024-08-07T21:21:04.765Z] 21:21:04     INFO - STDERR: :
[task 2024-08-07T21:21:04.765Z] 21:21:04     INFO - STDERR: Traceback (most recent call last):
[task 2024-08-07T21:21:04.766Z] 21:21:04     INFO - SUITE-END | took 593s
[task 2024-08-07T21:21:04.771Z] 21:21:04     INFO - STDERR:   File "/builds/worker/workspace/build/venv/lib/python3.8/site-packages/mozlog/logtypes.py", line 135, in __call__
[task 2024-08-07T21:21:04.771Z] 21:21:04     INFO - Got 0 unexpected results, with 0 unexpected passes
[task 2024-08-07T21:21:04.771Z] 21:21:04     INFO - STDERR:     
[task 2024-08-07T21:21:04.771Z] 21:21:04     INFO - STDERR: return self.convert(value)
[task 2024-08-07T21:21:04.774Z] 21:21:04     INFO - STDERR:   File "/builds/worker/workspace/build/venv/lib/python3.8/site-packages/mozlog/logtypes.py", line 251, in convert
[task 2024-08-07T21:21:04.774Z] 21:21:04     INFO - STDERR:     
[task 2024-08-07T21:21:04.774Z] 21:21:04     INFO - STDERR: return [self.item_type.convert(item) for item in data]
[task 2024-08-07T21:21:04.774Z] 21:21:04     INFO - STDERR:   File "/builds/worker/workspace/build/venv/lib/python3.8/site-packages/mozlog/logtypes.py", line 251, in <listcomp>
[task 2024-08-07T21:21:04.774Z] 21:21:04     INFO - STDERR:     
[task 2024-08-07T21:21:04.774Z] 21:21:04     INFO - STDERR: return [self.item_type.convert(item) for item in data]
[task 2024-08-07T21:21:04.775Z] 21:21:04     INFO - STDERR:   File "/builds/worker/workspace/build/venv/lib/python3.8/site-packages/mozlog/logtypes.py", line 208, in convert
[task 2024-08-07T21:21:04.775Z] 21:21:04     INFO - STDERR:     
[task 2024-08-07T21:21:04.775Z] 21:21:04     INFO - STDERR: raise ValueError
[task 2024-08-07T21:21:04.775Z] 21:21:04     INFO - STDERR: ValueError
[task 2024-08-07T21:21:04.775Z] 21:21:04     INFO - STDERR: 
[task 2024-08-07T21:21:04.775Z] 21:21:04     INFO - During handling of the above exception, another exception occurred:
[task 2024-08-07T21:21:04.775Z] 21:21:04     INFO - 
[task 2024-08-07T21:21:04.775Z] 21:21:04     INFO - STDERR: Traceback (most recent call last):
[task 2024-08-07T21:21:04.775Z] 21:21:04     INFO - STDERR:   File "/usr/lib/python3.8/threading.py", line 932, in _bootstrap_inner
[task 2024-08-07T21:21:04.775Z] 21:21:04     INFO - STDERR:     
[task 2024-08-07T21:21:04.775Z] 21:21:04     INFO - STDERR: self.run()
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR:   File "/usr/lib/python3.8/threading.py", line 870, in run
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR:     
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR: self._target(*self._args, **self._kwargs)
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR:   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/testrunner.py", line 467, in run_loop
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR:     
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR: new_state = self.wait_event()
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR:   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/testrunner.py", line 586, in wait_event
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR:     
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR: return f(*data)
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR:   File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/testrunner.py", line 795, in test_ended
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR:     
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR: self.logger.test_status(test.id,
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR:   File "/builds/worker/workspace/build/venv/lib/python3.8/site-packages/mozlog/logtypes.py", line 56, in inner
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR:     
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR: data = converter.convert(*args, **kwargs)
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR:   File "/builds/worker/workspace/build/venv/lib/python3.8/site-packages/mozlog/logtypes.py", line 100, in convert
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR:     
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR: out_value = self.args[key](value)
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR:   File "/builds/worker/workspace/build/venv/lib/python3.8/site-packages/mozlog/logtypes.py", line 137, in __call__
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR:     
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR: raise ValueError(
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR: ValueError
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR: : 
[task 2024-08-07T21:21:04.779Z] 21:21:04     INFO - STDERR: Failed to convert value ['CRASH'] of type list for field known_intermittent to type List
[task 2024-08-07T21:21:04.780Z] 21:21:04     INFO - wptserve Stopped WebTransport over HTTP/3 server on 127.0.0.1:11000
[task 2024-08-07T21:21:04.881Z] 21:21:04     INFO - wptserve Close on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 8889))
[task 2024-08-07T21:21:04.887Z] 21:21:04     INFO - wptserve Stopped http server on 127.0.0.1:8444
[task 2024-08-07T21:21:04.896Z] 21:21:04     INFO - wptserve Close on: (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 8888))
[task 2024-08-07T21:21:04.896Z] 21:21:04     INFO - wptserve Stopped http server on 127.0.0.1:9000
[task 2024-08-07T21:21:04.896Z] 21:21:04     INFO - wptserve Stopped http server on 127.0.0.1:8001
[task 2024-08-07T21:21:04.896Z] 21:21:04     INFO - wptserve Stopped http server on 127.0.0.1:8446
[task 2024-08-07T21:21:04.896Z] 21:21:04     INFO - wptserve Stopped http server on 127.0.0.1:8002
[task 2024-08-07T21:21:04.906Z] 21:21:04     INFO - wptserve Stopped http server on 127.0.0.1:8445
[task 2024-08-07T21:21:04.926Z] 21:21:04     INFO - wptserve Stopped http server on 127.0.0.1:8003
[task 2024-08-07T21:21:05.077Z] 21:21:05     INFO - wptserve Stopped http server on 127.0.0.1:8000
[task 2024-08-07T21:21:05.178Z] 21:21:05     INFO - wptserve Stopped http server on 127.0.0.1:8443
[task 2024-08-07T21:21:05.224Z] 21:21:05     INFO - Removed font: Ahem.ttf
[task 2024-08-07T21:21:05.276Z] 21:21:05     INFO - Closing logging queue
[task 2024-08-07T21:21:05.276Z] 21:21:05     INFO - queue closed
[task 2024-08-07T21:21:05.738Z] 21:21:05     INFO - Return code: 1
[task 2024-08-07T21:21:05.739Z] 21:21:05  WARNING - setting return code to 2
[task 2024-08-07T21:21:05.739Z] 21:21:05     INFO - Running post-action listener: _package_coverage_data
[task 2024-08-07T21:21:05.739Z] 21:21:05     INFO - Running post-action listener: _resource_record_post_action
[task 2024-08-07T21:21:05.739Z] 21:21:05     INFO - Running post-action listener: process_java_coverage_data
[task 2024-08-07T21:21:05.739Z] 21:21:05     INFO - Running post-action listener: stop_device
[task 2024-08-07T21:21:06.081Z] 21:21:06     INFO - /data/tombstones/tombstone_00 deleted
[task 2024-08-07T21:21:06.156Z] 21:21:06     INFO - /data/tombstones/tombstone_01 deleted
[task 2024-08-07T21:21:06.234Z] 21:21:06     INFO - /data/tombstones/tombstone_02 deleted
[task 2024-08-07T21:21:06.234Z] 21:21:06     INFO - Killing logcat pid 1480.
[task 2024-08-07T21:21:06.234Z] 21:21:06     INFO - Killing every process called qemu-system-x86_64
[task 2024-08-07T21:21:06.240Z] 21:21:06     INFO - [mozharness: 2024-08-07 21:21:06.240060Z] Finished run-tests step (success)
[task 2024-08-07T21:21:06.240Z] 21:21:06     INFO - Running post-run listener: _resource_record_post_run
[task 2024-08-07T21:21:06.513Z] 21:21:06     INFO - Total resource usage - Wall time: 645s; CPU: 29%; Read bytes: 0; Write bytes: 862285824; Read time: 0; Write time: 636432
[task 2024-08-07T21:21:06.513Z] 21:21:06     INFO - TinderboxPrint: CPU usage<br/>28.5%
[task 2024-08-07T21:21:06.513Z] 21:21:06     INFO - TinderboxPrint: I/O read bytes / time<br/>0 / 0
[task 2024-08-07T21:21:06.513Z] 21:21:06     INFO - TinderboxPrint: I/O write bytes / time<br/>862,285,824 / 636,432
[task 2024-08-07T21:21:06.513Z] 21:21:06     INFO - TinderboxPrint: CPU guest<br/>691.2 (11.9%)
[task 2024-08-07T21:21:06.513Z] 21:21:06     INFO - TinderboxPrint: CPU idle<br/>3,635.7 (62.7%)
[task 2024-08-07T21:21:06.513Z] 21:21:06     INFO - TinderboxPrint: CPU system<br/>427.1 (7.4%)
[task 2024-08-07T21:21:06.513Z] 21:21:06     INFO - TinderboxPrint: CPU user<br/>1,034.4 (17.8%)
[task 2024-08-07T21:21:06.513Z] 21:21:06     INFO - TinderboxPrint: Swap in / out<br/>0 / 0
[task 2024-08-07T21:21:06.514Z] 21:21:06     INFO - pull - Wall time: 0s; CPU: Can't collect data; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
[task 2024-08-07T21:21:06.515Z] 21:21:06     INFO - start-emulator - Wall time: 0s; CPU: Can't collect data; Read bytes: 0; Write bytes: 0; Read time: 0; Write time: 0
[task 2024-08-07T21:21:06.518Z] 21:21:06     INFO - verify-device - Wall time: 31s; CPU: 26%; Read bytes: 0; Write bytes: 330407936; Read time: 0; Write time: 269112
[task 2024-08-07T21:21:06.519Z] 21:21:06     INFO - install - Wall time: 10s; CPU: 35%; Read bytes: 0; Write bytes: 169639936; Read time: 0; Write time: 129812
[task 2024-08-07T21:21:06.567Z] 21:21:06     INFO - run-tests - Wall time: 604s; CPU: 29%; Read bytes: 0; Write bytes: 349376512; Read time: 0; Write time: 223440
[task 2024-08-07T21:21:07.934Z] 21:21:07  WARNING - returning nonzero exit status 2
[task 2024-08-07T21:21:08.022Z] cleanup
[task 2024-08-07T21:21:08.022Z] + cleanup
[task 2024-08-07T21:21:08.022Z] + local rv=2
[task 2024-08-07T21:21:08.022Z] + [[ -s /builds/worker/.xsession-errors ]]
[task 2024-08-07T21:21:08.022Z] + cp /builds/worker/.xsession-errors /builds/worker/artifacts/public/xsession-errors.log
[task 2024-08-07T21:21:08.023Z] + '[' ']'
[task 2024-08-07T21:21:08.023Z] + true
[task 2024-08-07T21:21:08.023Z] + cleanup_xvfb
[task 2024-08-07T21:21:08.023Z] ++ pidof Xvfb
[task 2024-08-07T21:21:08.026Z] + local xvfb_pid=58
[task 2024-08-07T21:21:08.026Z] + local vnc=false
[task 2024-08-07T21:21:08.026Z] + local interactive=false
[task 2024-08-07T21:21:08.026Z] + '[' -n 58 ']'
[task 2024-08-07T21:21:08.027Z] + [[ false == false ]]
[task 2024-08-07T21:21:08.027Z] + [[ false == false ]]
[task 2024-08-07T21:21:08.027Z] + kill 58
[task 2024-08-07T21:21:08.027Z] + screen -XS xvfb quit
[task 2024-08-07T21:21:08.028Z] + exit 2
[taskcluster 2024-08-07 21:21:08.670Z] === Task Finished ===
[taskcluster 2024-08-07 21:21:11.841Z] Unsuccessful task run with exit code: 2 completed in 797.85 seconds
Flags: needinfo?(sefeng)
Upstream PR was closed without merging
Pushed by sefeng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6c62047559a6 Cancel the loading=lazy iframe when it's load via a different way r=emilio,webdriver-reviewers
Upstream PR was closed without merging
Pushed by sefeng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d232f991af6a Cancel the loading=lazy iframe when it's load via a different way r=emilio,webdriver-reviewers
Upstream PR was closed without merging

Sean, please do not remove the test expectations for CDP which are currently set to expect a failure. We are not going to update the code for that deprecated protocol:

https://hg.mozilla.org/integration/autoland/diff/d232f991af6ad171d962530193e82d0111ea746b/remote/test/puppeteer/test/TestExpectations.json#l1.12

Pushed by sefeng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/40f19af2bb8a Cancel the loading=lazy iframe when it's load via a different way r=emilio,webdriver-reviewers
Flags: needinfo?(sefeng)
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
Upstream PR merged by moz-wptsync-bot

The patch landed in nightly and beta is affected.
:sefeng, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox131 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(sefeng)

I don't see the urgency of uplifting this patch to 131, given it has been existing for a couple of month.

So I'll leave it to ride the train, unless anyone thinks we should uplift it due to it's a P2 web-compat bug....

Flags: needinfo?(sefeng)
Regressions: 1918505
See Also: → 1923655

I inadvertently ran into this bug in bug 1923655, where it manifested once the test got uplifted to esr128.

Is the intent to uplift this to esr128 after it's reached release 132 without any issues?

Flags: needinfo?(sefeng)

I didn't have an intent to uplift this to esr128, but I am happy to uplift this if needed.

Gijs, let me know if you want me to make a patch that can apply cleanly to esr128.

Flags: needinfo?(sefeng)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: