1882674 - Remove media.ondevicechange.enabled pref

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, task)

Description

[Gregory Pappas [:gregp]]

MediaDevices.ondevicechange has been enabled by default for about 8 years now (bug 1308115). Is this pref still useful?

Comment 1

[Gregory Pappas [:gregp]]

• dom/webidl/MediaDevices.webidl#16
• modules/libpref/init/StaticPrefList.yaml#10993-10997

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

It's not useful to turn this pref off, as it would remove API surface that is now considered part of the web platform. The pref additionally does not actually turn off the event firing of the "devicechange" event, so it has not privacy benefit either. Good riddance.

Comment 3

[Ho Cheung]

Attachment: Bug 1882674 - Remove media.ondevicechange.enabled pref r=emilio

MediaDevices.ondevicechange has been enabled by default for about 8
years, and it looks like we can now remove it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/319a0eaef17a
Remove media.ondevicechange.enabled pref r=emilio

Comment 5

[Gregory Pappas [:gregp]]

Sheriffs will close the bug when your code change lands, you don't have to close it yourself 🙂

Comment 6

[Ho Cheung]

Thank you for your guidance. Currently the patch has landed on the autoland tree. I will wait for the patch to land on the tip tree.

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/319a0eaef17a