Closed Bug 1882967 Opened 2 years ago Closed 1 years ago

Create icon image by its blob and mimetype returned from Rust

Categories

(Firefox :: Address Bar, task, P2)

task

Tracking

()

RESOLVED FIXED
126 Branch
Tracking Status
firefox126 --- fixed

People

(Reporter: daisuke, Assigned: daisuke)

References

Details

Attachments

(1 file)

In the bug 1882954, as we will expose the icon mimetype, create the icon image with it.

Severity: -- → N/A
Priority: -- → P2

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:daisuke, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(daisuke)
Flags: needinfo?(adw)

Thanks BugBot, we'll need to wait until the Rust change that this depends on is vendored into m-c before landing this.

Flags: needinfo?(daisuke)
Flags: needinfo?(adw)

Oh actually this was vendored in, in bug 1885440 (see here for example). Daisuke would you like to land this? And then I guess we'll need a follow-up once https://github.com/mozilla/application-services/pull/6162 is merged and vendored.

Flags: needinfo?(daisuke)
No longer blocks: 1882954
Depends on: 1882954

Oh, I didn't realize it, thanks!
Yep, I will land it (then, address for the new struct in a follow-up)

Flags: needinfo?(daisuke)
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/feba370fe262 Create icon image by its blob and mimetype r=adw
Status: ASSIGNED → RESOLVED
Closed: 1 years ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: