1882971 - Pop3 downlaod does not use buffered write for writing to the file system

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, enhancement)

Description

[ISHIKAWA, Chiaki]

I have a set of patches for making the writing of messages to file system to use the buffered write. Bug 1242030
Currently C-C TB does not and it suffers from performance issue.
With/without buffered write is quite clear when I test the message download from a local pop3 server, especially when I test it by sending 1MB files (a JPEG camera image can be like this one of these days. It can be larger.)

Anyway, my local patch set assumed all the write were via C++ routines and everything was done using the pop3 logic in the C++ code.
Well, after Ben's "From" line handling patch landed, I had tough time to make the buffering to work and eventually I realize that writing of each line in a message from POP3 server is done by Pop3client.jsm code invoking
IncorporateWrite() defined in nsPop3Sink.cpp code these days.
We need to make sure the filestream used by that routine a buffered stream.

There are other minor changes necessary such as UNDEFINE SEEK_TO_END in nsPop3Sink.cpp to make buffered write
effective. (Otherwise, I think seek flushes the buffer thus negating the all the advantage of buffered write.)
These are handled in Bug 1242030 and I am just learning how to use the latest patch submission method using moz-phab.

So this is just a start.
I am going to post a patch for this using moz-phab.

Comment 1

[ISHIKAWA, Chiaki]

Attachment: Bug 1882971 Make the file stream used by Pop3 a buffered stream, r=BenC

Comment 2

[ISHIKAWA, Chiaki]

I think I somehow managed to upload the patch.
Initially I mangled the request review line (I wrote r?=benc which moz-phab did not grok as review request phrase, and treated as =benc. So it ended up as a draft (work in progress). Not visible from this bugzilla entry.
I "asked for review", then its status changed and now it is visible from this bugzilla.
OK, so it works like this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8a74d750e2ec
Make the file stream used by Pop3 a buffered stream. r=benc