getComputedStyle WPT failures in query-encoding/attributes.sub.html
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
People
(Reporter: valentin, Assigned: edgul)
Details
Attachments
(1 file)
FAIL message: assert_true: url("http://web-platform.test:8000/html/infrastructure/urls/resolving-urls/query-encoding/attributes.sub.html?%C3%BF") did not end with ?%FF") expected true got false
Failing tests:
getComputedStyle <body background>
getComputedStyle <table background>
getComputedStyle <thead background>
getComputedStyle <tbody background>
getComputedStyle <tfoot background>
getComputedStyle <tr background>
getComputedStyle <td background>
getComputedStyle <th background>
|
Reporter | |
Comment 1•9 months ago
|
||
I think this is coming from here: https://searchfox.org/mozilla-central/rev/c036a209f5a2c3163d1277ee2b7becaab2f79dbd/layout/style/nsStyleStruct.cpp#92,109
We should also pass the pages's/Element encoding into the method.
|
||
Comment 2•9 months ago
|
||
(In reply to Valentin Gosu [:valentin] (he/him) from comment #1)
I think this is coming from here: https://searchfox.org/mozilla-central/rev/c036a209f5a2c3163d1277ee2b7becaab2f79dbd/layout/style/nsStyleStruct.cpp#92,109
This test is about the URL query, not fragment (local ref). So I think the relevant code will be somewhere else (but the same issue, we're just assuming utf-8 and not respecting the page's encoding).
|
|
Reporter | |
Comment 3•2 months ago
|
||
Looking at all the places in layout/style that call NS_NewURI these are:
mozilla::GlobalStyleSheetCache::LoadSheetFromSharedMemory
mozilla::GlobalStyleSheetCache::LoadSheetURL
mozilla::StyleCssUrl::GetURI
mozilla::StyleSheet::Constructor
As far as I can tell, none of these pass in a charset attribute.
Description
•