Closed Bug 1883058 Opened 3 months ago Closed 1 month ago

moz-toggle should only show active state on hover

Categories

(Toolkit :: UI Widgets, defect, P3)

defect

Tracking

()

RESOLVED FIXED
126 Branch
Tracking Status
firefox126 --- fixed

People

(Reporter: mstriemer, Assigned: camilledavisdev, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Attachments

(1 file)

We should only be showing the active state styling when an input will be activated when the pointer is released. Currently our moz-toggle is showing the active styling on :active though, which means if you press and hold, then move the pointer away it is still showing as active

The active styling should only be shown on :hover:active instead

There are several occurences of :active without :hover in moz-toggle.css, here's an example searchfox

Assignee: nobody → camilledavisdev
Status: NEW → ASSIGNED

Just tested the changes manually -- does this also need an automated test?

Attachment #9394301 - Attachment description: WIP: Bug 1883058 - Only show moz-toggle active state on hover. → Bug 1883058 - Only show moz-toggle active state on hover.
Pushed by tgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50bf4ac6402c
Only show moz-toggle active state on hover. r=tgiles
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: