1883254 - firefox nightly fails to link in: function `mozilla::widget::DBusMenuBar::OnNameOwnerChanged()' with undefined reference to `mozilla::widget::DBusProxyCall

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[tt_1]

Attachment: build.log.xz

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/115.0

Steps to reproduce:

hello, I just compiled latest firefox nightly

Actual results:

I got this linking error:

45:41.07 /usr/libexec/gcc/armv7a-unknown-linux-gnueabihf/ld.bfd: /var/tmp/portage/portage/www-client/firefox-125.0/work/firefox_build/toolkit/library/build/../../../widget/gtk/Unified_cpp_widget_gtk0.o: in function mozilla::widget::DBusMenuBar::OnNameOwnerChanged()': 45:41.07 Unified_cpp_widget_gtk0.cpp:(.text._ZN7mozilla6widget11DBusMenuBar18OnNameOwnerChangedEv+0xf0): undefined reference tomozilla::widget::DBusProxyCall(_GDBusProxy*, char const*, _GVariant*, GDBusCallFlags, int, _GCancellable*)'
45:41.07 /usr/libexec/gcc/armv7a-unknown-linux-gnueabihf/ld.bfd: /var/tmp/portage/portage/www-client/firefox-125.0/work/firefox_build/toolkit/library/build/../../../widget/gtk/Unified_cpp_widget_gtk0.o: in function mozilla::widget::DBusMenuBar::Create(mozilla::dom::Element*)': 45:41.07 Unified_cpp_widget_gtk0.cpp:(.text._ZN7mozilla6widget11DBusMenuBar6CreateEPNS_3dom7ElementE+0x4e): undefined reference tomozilla::widget::CreateDBusProxyForBus(GBusType, GDBusProxyFlags, _GDBusInterfaceInfo*, char const*, char const*, char const*, _GCancellable*)'
45:41.07 /usr/libexec/gcc/armv7a-unknown-linux-gnueabihf/ld.bfd: libxul.so: hidden symbol `_ZN7mozilla6widget21CreateDBusProxyForBusE8GBusType15GDBusProxyFlagsP19_GDBusInterfaceInfoPKcS6_S6_P13_GCancellable' isn't defined
45:41.07 /usr/libexec/gcc/armv7a-unknown-linux-gnueabihf/ld.bfd: final link failed: bad value
45:41.07 collect2: error: ld returned 1 exit status

Expected results:

I expect the linker to give me a nice firefox nightly binary

This is propably an incomplete fix from bug 1883184

this is a build without dbus, with X11

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:uhhadd, since you are the author of the regressor, bug 1883184, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1883254 - Fix dbus-disabled build after bug 1883184. r=stransky

Ugh

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1883184

Comment 5

[tt_1]

the fix is working for me, thanks a lot!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f29f37a00080
Fix dbus-disabled build after bug 1883184. r=stransky

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f29f37a00080