1883282 - Log message incorrectly logs split string parts

Status: RESOLVED FIXED

(Core :: Networking, defect, P3)

Description

[David Parks [:handyman]]

The log message here is incorrect.

      for (const nsACString& suffix : list.Split(',')) {
        LOG(("  appending DNS suffix from registry: %s\n",
             suffix.BeginReading()));

nsTSubstring::Split efficiently returns substrings that aren't null-terminated. They need to be copied to a null terminated string if they are going to be used that way, e.g. with PromiseFlatCString.

Comment 1

[Manuel Bucher [:manuel]]

Documentation on PromiseFlatCString for anyone interested in taking this bug as a good-first-bug.

Comment 2

[mike.maksymowych]

Attachment: Bug 1883282 - Use PromiseFlatCString to null-terminate log. r=handyman

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit BugBot documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5cc8ff6f2c0
Use PromiseFlatCString to null-terminate log. r=necko-reviewers,valentin

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e5cc8ff6f2c0