1883402 - Tidy up add-on related functions in the search service

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

Whilst working on the search service in other bugs, I noticed a couple of items that we could tidy up:

• nsISearchService.addEnginesFromExtension returns a list of engines that were added, but we never use the returned list.
• _createAndAddEngine could be better named, but also can be called directly in more instances rather than going through #installExtensionEngine.
  • Avoiding the intermediate will mean less complexity, and make it easier to know that we can remove #installExtensionEngine when we remove the old search configuration.
  • We can also clean up the console logging a bit.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1883402 - Stop returning engines from nsISearchService.addEnginesFromExtension as they are never used. r?#search-reviewers!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1883402 - Call _createAndAddEngine directly in more cases and rename it. r?#search-reviewers!

_createAndAddEngine (renamed to #createAndAddAddibEngine) can be called directly in more cases,
because startup engines are only ever single-locale based. Application provided engines
(which could be multi-locale) are treated differently.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d42ed22ce9cc
Stop returning engines from nsISearchService.addEnginesFromExtension as they are never used. r=search-reviewers,daleharvey
https://hg.mozilla.org/integration/autoland/rev/f1f2f748d16f
Call _createAndAddEngine directly in more cases and rename it. r=search-reviewers,daleharvey

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d42ed22ce9cc
https://hg.mozilla.org/mozilla-central/rev/f1f2f748d16f