1883476 - Default Agent set default doesn't fall back to Windows Settings on error.

Status: RESOLVED FIXED

(Toolkit :: Default Browser Agent, defect, P1)

Description

[Nick Rishel [:nrishel]]

The set default path we migrated to in the JavaScript implementation of Windows Default Agent intervention does not trigger the Windows Settings fallback. We should use the Shell Service set default implementation instead of the Default Agent implementation (n.b. we should move the Default Agent implementation into the Shell Service eventually).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1867144

Comment 2

[Nick Rishel [:nrishel]]

Attachment: Bug 1883476 - Use ShellService when setting default from the Default Agent intervention. r=nalexander

Comment 3

[Nick Rishel [:nrishel]]

Attachment: Bug 1883476 - Part 3: Remove dead launched from WDBA telemetry. r=nalexander

Backed out changeset 5d6127a9b7ed.

Comment 4

[Nick Rishel [:nrishel]]

Attachment: Bug 1883476 - Use ShellService when setting default from the Default Agent intervention. r=nalexander

Original Revision: https://phabricator.services.mozilla.com/D203504

Comment 5

[Phabricator Automation]

Uplift Approval Request

• String changes made/needed: n/a
• Code covered by automated testing: no
• User impact if declined: Set default from default flow can fail in some cases without providing a fallback.
• Fix verified in Nightly: yes
• Risk associated with taking this patch: Low
• Is Android affected?: no
• Steps to reproduce for manual QE testing: n/a
• Needs manual QE test: no
• Explanation of risk level: Trivial change, just an alternative path to set default.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4c14c683de5
Use ShellService when setting default from the Default Agent intervention. r=nalexander

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c4c14c683de5

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e3a7ca90b31

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc8bdcfbcd9c
Part 3: Remove dead launched from WDBA telemetry. r=nalexander

Comment 10

[Cosmin Sabou [:CosminS]]

Backed out for causing windows build bustages.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=bc8bdcfbcd9c788f4b8dbd7806f7d31d6e8e63ec&selectedTaskRun=c0vPhzLhSeOnkREv498Ung.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=449874388&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/e420cccb7ec93777f67029159c469f4c5063ad6f

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bfafcbe27d65
Part 3: Remove dead launched from WDBA telemetry. r=nalexander

Comment 12

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/bfafcbe27d65