1883486 - [wpt-sync] Sync PR 44912 - DOM: Implement Observable#from() conversion operator

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44912 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44912
Details from upstream follow.

Dominic Farolino <[e-mail]> wrote:

DOM: Implement Observable#from() conversion operator

Note: This CL is mostly good to go but is not ready for DOM OWNER review
yet until:

1. I get bindings expert opinions
2. Write a real CL description

Bug: 40282760
Change-Id: I6b392ba77221fb1a77e334aa5f151ed6518419ed

Reviewed-on: https://chromium-review.googlesource.com/5337908
WPT-Export-Revision: fa9d8ab043102650563a2dca55f4e9ec2f69a59a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c90727b9ff1770ec5ba8a4a306010ac845967f34

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 13 subtests

Status Summary

Firefox

OK : 2
FAIL: 26

Chrome

OK : 2
PASS: 2
FAIL: 24

Safari

OK : 2
FAIL: 26

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /dom/observable/tentative/observable-from.any.worker.html [wpt.fyi]
  • from(): Observable.from() is a function: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): Failed conversions: FAIL (Chrome: PASS, Safari: FAIL)
  • from(): Given an observable, it returns that exact observable: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): Given an array: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): Iterable converts to Observable: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): [Symbol.iterator] side-effects (one observable): FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): [Symbol.iterator] side-effects (many observables): FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): [Symbol.iterator] next() throws error: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): Converts Promise to Observable: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): Converts rejected Promise to Observable. No unhandledrejection event when error is handled by subscription: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): Rejections not handled by subscription are reported to the global, and still not sent as an unhandledrejection event: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): Observable that implements @@iterator protocol gets converted as an Observable, not iterator: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): Promise that implements @@iterator protocol gets converted as an iterable, not Promise: FAIL (Chrome: FAIL, Safari: FAIL)
• /dom/observable/tentative/observable-from.any.html [wpt.fyi]
  • from(): Observable.from() is a function: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): Failed conversions: FAIL (Chrome: PASS, Safari: FAIL)
  • from(): Given an observable, it returns that exact observable: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): Given an array: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): Iterable converts to Observable: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): [Symbol.iterator] side-effects (one observable): FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): [Symbol.iterator] side-effects (many observables): FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): [Symbol.iterator] next() throws error: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): Converts Promise to Observable: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): Converts rejected Promise to Observable. No unhandledrejection event when error is handled by subscription: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): Rejections not handled by subscription are reported to the global, and still not sent as an unhandledrejection event: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): Observable that implements @@iterator protocol gets converted as an Observable, not iterator: FAIL (Chrome: FAIL, Safari: FAIL)
  • from(): Promise that implements @@iterator protocol gets converted as an iterable, not Promise: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d993819bb8c3
[wpt PR 44912] - DOM: Implement Observable#from() conversion operator, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c0263388b229
[wpt PR 44912] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d993819bb8c3
https://hg.mozilla.org/mozilla-central/rev/c0263388b229