1883508 - gfx/gl/GLContextProviderEAGL.mm:24:16: error: out-of-line definition of 'GLContextEAGL' does not match any declaration in 'mozilla::gl::GLContextEAGL'

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Mike Hommey [:glandium]]

Building with --enable-project=mobile/ios fails with, among other things:

/tmp/gecko-ios/gfx/gl/GLContextProviderEAGL.mm:24:16: error: out-of-line definition of 'GLContextEAGL' does not match any declaration in 'mozilla::gl::GLContextEAGL'
   24 | GLContextEAGL::GLContextEAGL(const GLContextDesc& desc, EAGLContext* context,
      |                ^~~~~~~~~~~~~
/tmp/gecko-ios/gfx/gl/GLContextProviderEAGL.mm:108:8: error: unknown type name 'PRFuncPtr'
  108 | static PRFuncPtr GLAPIENTRY GetLoadedProcAddress(const char* const name) {
      |        ^
/tmp/gecko-ios/gfx/gl/GLContextProviderEAGL.mm:109:3: error: unknown type name 'PRLibrary'; did you mean 'FT_Library'?
  109 |   PRLibrary* lib = nullptr;
      |   ^~~~~~~~~
      |   FT_Library
/tmp/gecko-ios/obj-aarch64-apple-ios/dist/include/mozilla/gfx/2D.h:54:25: note: 'FT_Library' declared here
   54 | typedef FT_LibraryRec_* FT_Library;
      |                         ^
/tmp/gecko-ios/gfx/gl/GLContextProviderEAGL.mm:110:60: error: use of undeclared identifier 'leakedLibRef'
  110 |   const auto& ret = PR_FindFunctionSymbolAndLibrary(name, &leakedLibRef);
      |                                                            ^
/tmp/gecko-ios/gfx/gl/GLContextProviderEAGL.mm:112:5: error: use of undeclared identifier 'PR_UnloadLibrary'
  112 |     PR_UnloadLibrary(lib);
      |     ^
/tmp/gecko/iPhoneOS17.4.sdk/usr/include/c++/v1/__type_traits/is_trivially_destructible.h:26:38: error: incomplete type 'mozilla::gl::SymbolLoader' used in type trait expression
   26 |     : public integral_constant<bool, __is_trivially_destructible(_Tp)> {};
      |                                      ^
/tmp/gecko-ios/gfx/gl/GLContextProviderEAGL.mm:164:11: error: no matching constructor for initialization of 'GLContextEAGL'
  164 |       new GLContextEAGL(desc, context, sharedContext);
      |           ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/gecko-ios/gfx/gl/GLContextEAGL.h:25:3: note: candidate constructor not viable: requires 4 arguments, but 3 were provided
   25 |   GLContextEAGL(const GLContextDesc&, EAGLContext* context,
      |   ^             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   26 |                 GLContext* sharedContext, ContextProfile profile);
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/gecko-ios/gfx/gl/GLContextEAGL.h:18:7: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 3 were provided
   18 | class GLContextEAGL : public GLContext {
      |       ^~~~~~~~~~~~~
/tmp/gecko-ios/gfx/gl/GLContextProviderEAGL.mm:198:8: error: no member named 'isOffcreen' in 'mozilla::gl::GLContextDesc'; did you mean 'isOffscreen'?
  198 |   desc.isOffcreen = true;
      |        ^~~~~~~~~~
      |        isOffscreen
/tmp/gecko-ios/gfx/gl/GLContextTypes.h:48:8: note: 'isOffscreen' declared here
   48 |   bool isOffscreen = false;
      |        ^
/tmp/gecko-ios/gfx/gl/GLContextProviderEAGL.mm:211:69: error: too few arguments to function call, expected 2, have 1
  211 |     RefPtr<GLContext> temp = CreateHeadless(CreateContextFlags::NONE);
      |                              ~~~~~~~~~~~~~~                         ^
/tmp/gecko-ios/gfx/gl/GLContextProviderEAGL.mm:195:52: note: 'CreateHeadless' declared here
  195 | already_AddRefed<GLContext> GLContextProviderEAGL::CreateHeadless(
      |                                                    ^
  196 |     const GLContextCreateDesc& createDesc, nsACString* const out_failureId) {
      |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1883508 - Fix build errors in GLContextProviderEAGL.mm.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf981c29204b
Fix build errors in GLContextProviderEAGL.mm. r=gfx-reviewers,jgilbert

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/cf981c29204b