1883525 - HDR videos on youtube flicker when scrolling throught a list in the video controls

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect, P3)

Description

[Jonathan Almeida [:jonalmeida]]

Attachment: Video of the bug.mp4

Steps to reproduce

1. Open the youtube link provided in the bug report.
2. Click on the 'Settings' cog, then 'Quality'.
3. Scroll through the list of quality options (it doesn't matter if the video is playing or not).

Expected result

• The video should not flicker.

Actual result

• Video flickers while scrolling up and down (see video attachment).

Additional information

• HDR video doesn't seem to get brighter with an external display (Dell U2718Q), so this bug is not visible there.
• Profiles:
  • Firefox: https://share.firefox.dev/3VlTyqD
  • Graphics: https://share.firefox.dev/3uOAlTA
• Mac OS 14.2.1 (23C71), Macbook Pro M1 Max

Comment 1

[Paul Adenot (:padenot)]

Brad, do you have an idea of what's going on here?

Comment 2

[Brad Werth [:bradwerth]]

We are probably hitting some case in WebRender where YouTube UI engages some overlay mode that prevents WR from allowing the video to be isolated as an external texture -- that's the same problem that causes Bug 1872892. The work to fix this will be at least partly handled by Bug 1855573, so I'll make that a blocker.

Comment 3

[Brad Werth [:bradwerth]]

I believe, this has been largely fixed by the landing of Bug 1872892. Would you please re-test on your setup?

However, there's a remaining problem with new Steps to Reproduce:

1. Login to YouTube and change appearance to Dark Mode.
2. View a HDR video like https://www.youtube.com/watch?v=LXb3EKWsInQ, click on the gear and turn on Ambient Mode.
3. Attempt to scroll up (using a touchpad?).

The video will desaturate, which is an indication that the video surface is no longer promoted. I'll probably open this as a new Bug rather than keeping this one open.

Comment 4

[Brad Werth [:bradwerth]]

(In reply to Brad Werth [:bradwerth] from comment #3)

The video will desaturate, which is an indication that the video surface is no longer promoted. I'll probably open this as a new Bug rather than keeping this one open.

I've opened this as a new issue in Bug 1899898.

Comment 5

[Jonathan Almeida [:jonalmeida]]

This is fixed for me on 128.0a1.20240530213713, thanks Brad!

Although, I've come across another bug as well and I've filed bug 1899938 for this with you cc'd.