1883546 - [wpt-sync] Sync PR 44924 - Revert "Reland "[FedCM] Allow button flow to replace widget flow""

Status: RESOLVED INVALID

(Core :: DOM: Credential Management, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44924 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44924
Details from upstream follow.

Peter Kotwicz <[e-mail]> wrote:

Revert "Reland "[FedCM] Allow button flow to replace widget flow""

This reverts commit 6d087d36fa95a3ae9b42c43844c330c9df0cade0.

Reason for revert:
fedcm-button-mode-basics.https.html which was introduced by this CL fails on almost all the runs.
Sample failing bot run https://ci.chromium.org/ui/p/chromium/builders/ci/Mac13%20Tests%20(dbg)/6836/overview

Original change's description:

Reland "[FedCM] Allow button flow to replace widget flow"

This reverts commit b57a0adddbd8aaa68fb06cd5cfd24a33296728ea.

Reason for revert: Fixed test in patchset 2

Original change's description:

Revert "[FedCM] Allow button flow to replace widget flow"

This reverts commit a2783105732c27a57dd0c3e1100730cc4aec32e0.

Reason for revert: Suspected of causing failures on WebKit Linux Leak: https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/60801/overview (and other runs since)

Original change's description:

[FedCM] Allow button flow to replace widget flow

Since button flow implies stronger user login intention of, it should
take precedence over the widget flow. In particular:

1. If there's an in-flight button request, reject any coming widget request
2. If there's an in-flight widget request, replace it with the button request

This patch also fixes an issue where we persisted the rp_mode_ after a
button flow.

Bug: 41483050
Change-Id: Ic75ba4ab359a9247f4c41b75ad84f7a3cabeb0c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5321982
Commit-Queue: Yi Gu \<[e-mail]>
Reviewed-by: Christian Biesinger \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1265238}

Bug: 41483050
Change-Id: I82728a8ea02194f46eed086015473975a4017dc4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5317868
Bot-Commit: Rubber Stamper \<[e-mail]>
Commit-Queue: Stephen McGruer \<[e-mail]>
Reviewed-by: Yi Gu \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1265306}

Bug: 41483050
Change-Id: I600b03200b95e4f5112f2a1ae45a4c8675ce7b28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5327886
Reviewed-by: Christian Biesinger \<[e-mail]>
Commit-Queue: Yi Gu \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1265980}

Bug: 41483050
Change-Id: Ifc8dd171781448e98fa4851d133b67056144588b

Reviewed-on: https://chromium-review.googlesource.com/5340975
WPT-Export-Revision: cdc47f4d675ddf9cfec2e380bec39b49f6e6a60f