1883562 - Make `AutoBlockElementsJoiner` work with one range instead of array of ranges

Status: RESOLVED FIXED

(Core :: DOM: Editor, task)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

It tries to work with multiple ranges, but it stores members only from the first range of the array. Therefore, it may get odd result. I think that it should work per range and the user should use it in a loop of iterating the ranges.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1883562 - part 1: Make `AutoBlockElementsJoiner` work with one range r=m_kato!

It and its helper class, AutoInclusiveAncestorBlockElementsJoiner work with
multiple ranges, but they handle special cases only with the first range.
That means that deleting content will be different if same structure is selected
with multiple ranges and that must be not expected by the users.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1883562 - part 2: Make `EditorBase::DeleteRangesWithTransaction` and the fallback path of `AutoDeleteRangesHandler` work with single range r=m_kato!,#dom-core

Although from the maintenance cost point of view, we should not duplicate
EditorBase::DeleteRangesWithTransaction, but let's add a wrapper for it
for making the callers simpler.

Depends on D203853

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc5f86f00169
part 1: Make `AutoBlockElementsJoiner` work with one range r=m_kato
https://hg.mozilla.org/integration/autoland/rev/2947b8cd9661
part 2: Make `EditorBase::DeleteRangesWithTransaction` and the fallback path of `AutoDeleteRangesHandler` work with single range r=m_kato

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cc5f86f00169
https://hg.mozilla.org/mozilla-central/rev/2947b8cd9661