1883724 - Enable Screen Wake Lock API only in early beta

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P1)

Description

[Vincent Hilla [:vhilla]]

Due to the problems in Bug 1882344 and concerns about more crashes appearing, we will keep Screen Wake Lock API disabled in release.

Comment 1

[Vincent Hilla [:vhilla]]

Attachment: Bug 1883724 - Disable Screen Wake Lock in release. r=edgar

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1dedc536b88
Disable Screen Wake Lock in release. r=edgar

Comment 3

[Cristian Tuns]

Backed out for causing build bustages in StaticPrefList.yaml

• Backout link
• Push with failures
• Failure Log
• Failure line: gmake[3]: *** [backend.mk:156: js/public/.deps/PrefsGenerated.h.stub] Error 1

Comment 4

[Vincent Hilla [:vhilla]]

Comment on attachment 9389458 [details]
Bug 1883724 - Disable Screen Wake Lock in release. r=edgar

Beta/Release Uplift Approval Request

• User impact if declined: We are concerned that some wake locks might fail to be released. This would cause user devices to not turn off the display automatically.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky, as we merely stop the API in early beta from riding the train to release
• String changes made/needed:
• Is Android affected?: Yes

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac4733a02b2d
Disable Screen Wake Lock in release. r=edgar

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/ac4733a02b2d

Comment 7

[Edgar Chen [:edgar] (PTO until 02/09)]

Attachment: Bug 1883724 - Disable Screen Wake Lock in release.

Original Revision: https://phabricator.services.mozilla.com/D203644

Comment 8

[Phabricator Automation]

Uplift Approval Request

• Code covered by automated testing: yes
• Risk associated with taking this patch: Low
• Needs manual QE test: no
• Explanation of risk level: Not risky, as we merely stop the API in early beta from riding the train to release
• String changes made/needed: None
• Is Android affected?: yes
• Fix verified in Nightly: no
• User impact if declined: We are concerned that some wake locks might fail to be released. This would cause user devices to not turn off the display automatically.
• Steps to reproduce for manual QE testing: None

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2cfab6f4b4a8