1883760 - Receiving new Mails from Server gets stuck - if chunks of multiline response arrive without crlf (only newline)

Status: RESOLVED FIXED

(MailNews Core :: Networking: POP, defect)

Description

[bugzilla22]

Steps to reproduce:

Trying to read mails via pop3 from an existing account having 15000+ Mails on server after having set up thunderbird newls.
Only reading header from Mail server.

Actual results:

after a few 1000+ mails suddently the message reading stops.
This alwas happens in case the final '\n' of the message is transmit in a new tcp package.
e.g.
TCP package 1 "....\r\n.\r"
TCP package 2 "\n"

In this case the last TCP package containing the end of the transmission is not parsed and as the server does not send anything more a timeout error happens and thunderbird stops fetching any further mails from that acocunt.

The issue lies in Pop3Client.jsm _onData function and was introduced the fix of Bug 1774732 / revision 36198 which adds:
if (stringPayload.includes("\r\n")) {
Here the parsing of a data chunk is started only in case the data contains "\r\n". If the "\r" was received in the first data chunk together with other "\r\n" the data would be parsed. The next data chunk containing only a sinlge "\n" will never be parsed.
Chaning this line into
if (stringPayload.includes("\n")) {
fixes this issue, as tested with a local build

Expected results:

All mails shall be read from a server independant how they are transmitted in tcp packages

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: Bug 1883760 - Allow chunks of pop3 multiline response to arrive without crlf (only newline). r=freaktechnik

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5c2463c9c29c
Allow chunks of pop3 multiline response to arrive without crlf (only newline). r=freaktechnik

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9389894 [details]
Bug 1883760 - Allow chunks of pop3 multiline response to arrive without crlf (only newline). r=freaktechnik

[Approval Request Comment]
User impact if declined: pop3 download can get stuck downloading
Testing completed (on c-c, etc.): c-c, beta 125
Risk to taking this patch (and alternatives if risky): fairly safe

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9389894 [details]
Bug 1883760 - Allow chunks of pop3 multiline response to arrive without crlf (only newline). r=freaktechnik

[Triage Comment]
Approved for esr115

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 115.10.0:
https://hg.mozilla.org/releases/comm-esr115/rev/e09ebe653827