1883847 - Create WorkerTargets for Shared Worker from the server codebase

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[Alexandre Poirot [:ochameau]]

Similarly to bug 1651522, we should drop the legacy worker listener in favor of creating the worker targets directly from the server, via the Watcher framework.

Bug 1866814 should drastically simplify how to support new type of worker.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1883847 - [devtools] Add support for server side SHARED_WORKER target support.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:ochameau, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Alex was away for a bit

Comment 4

[Alexandre Poirot [:ochameau]]

I'll land this alongside bug 1651518 as try is failing if I land only this patch.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8a2473c47c0
[devtools] Add support for server side SHARED_WORKER target support. r=devtools-reviewers,nchevobbe

Comment 6

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/b8a2473c47c0

Comment 7

[Cristina Horotan [:chorotan]]

Backed out 8 changesets (Bug 1651518, Bug 1883847) for causing damp failures at toolbox/browser-toolbox.js

Backout: https://hg.mozilla.org/integration/autoland/rev/80ae2c7908e4cc558336a6f6a78097d9c2c9317d

Failure push:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=windows%2C10%2Cx64%2Cwebrender%2Cshippable%2Copt%2Ctalos%2Cperformance%2Ctests%2Ctest-windows10-64-shippable-qr%2Fopt-talos-damp-other%2Cdamp-other&revision=4ec70db12f4878d64588b475b31299849fc842c2

Failure log: https://treeherder.mozilla.org/logviewer?job_id=459092764&repo=autoland&lineNumber=1746

Comment 8

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/80ae2c7908e4

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af28e5f719e8
[devtools] Add support for server side SHARED_WORKER target support. r=devtools-reviewers,nchevobbe

Comment 10

[Cristian Tuns]

Backed out for causing dt failures in nsTArray.h

• Backout link
• Push with failures
• Failure Log
• Failure line: SUMMARY: ThreadSanitizer: data race /builds/worker/workspace/obj-build/dist/include/nsTArray.h:397:43 in Length
  SUMMARY: ThreadSanitizer: data race /builds/worker/workspace/obj-build/dist/include/nsTArray.h:2694:23 in AppendElementInternal<nsTArrayInfallibleAllocator, mozilla::dom::WorkerRunnable *const &>

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ca692626205
[devtools] Add support for server side SHARED_WORKER target support. r=devtools-reviewers,nchevobbe

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2ca692626205