1883873 - Make SurfaceInfo::get_surface_rect return a DeviceIntRect

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P3)

Comment 1

[Nicolas Silva [:nical]]

Attachment: Bug 1883873 - Make SurfaceInfo::get_surface_rect return a DeviceIntRect. r=#gfx-reviewers

While investigating why get_surface_rect sometimes returns an empty rect (causing bad render task sizes), I noticed that all users of get_surface_rect use it to size surfaces, rely on the returned rect to be snapped to integer coordinates, and some even round the coordinates a second time. The documentation of the function states that its purpose is to provide a rect suitable for surface allocation. This patch bakes the expectation into the type and removes some redundant operations.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eae4f8752721
Make SurfaceInfo::get_surface_rect return a DeviceIntRect. r=gfx-reviewers,gw

Comment 3

[tszentpeteri]

Backed out for causing webrender bustages in conftest.c

• Backout link
• Push with failures
• Failure Log
• Failure lines: [servo-fontconfig-sys 5.1.0] conftest.c:85:26: fatal error: atomic.h: No such file or directory
  subprocess.CalledProcessError: Command '['../target/release/wrench', '--no-scissor', '--headless', 'reftest']' died with <Signals.SIGABRT: 6>.

We also have mochitest failures like this: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=11d507e55b6e2588004ca5fef5c00799b6baf900&searchStr=android%2C7.0%2Cx86-64%2Clite%2Cwebrender%2Copt%2Cmochitests%2Cthat%2Crun%2Con%2Cfission%2Cwith%2Cisolatehighvalue%2Cisolation%2Cstrategy%2C%28android-specific%29%2Ctest-android-em-7.0-x86_64-lite-qr%2Fopt-geckoview-mochitest-plain-fis-hv%2C5&selectedTaskRun=In6bOe_sQ7G6Tn5TcKOr0A.0&tochange=987284103c26599be1cfe7738d0780c6253fb5cb

Comment 4

[Nicolas Silva [:nical]]

The errors look unrelated and I'm not getting them on try. I'll rebase and reland.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/038ff8035b29
Make SurfaceInfo::get_surface_rect return a DeviceIntRect. r=gfx-reviewers,gw

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/038ff8035b29