1883909 - Move logic from FormAutofillContent to FormAutofillChild

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P2)

Description

[Dimi Lee [:dimi]]

We should maintain state based on frame, not based on process.
This is a prerequisite work needed for supporting autofill across iframe.

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1883909 - P1. Remove unused variables in FormAutofillChild r=#credential-management-reviewers

this._alreadyDOMContentLoaded variable is not needed in the logic.
Its purpose is already covered by doc.readyState

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1883909 - P2. Move logic from FormAutofillContent to FormAutofillChild r=#credential-management-reviewers

In this patch, we move most of the logic from FormAutofillContent to FormAutofillChild.
This is the first step in removing FormAutofillContent from the formautofill module.
The purpose is to eliminate per-process state and maintain per-frame state instead.
Doing so would allow us to support autofill across iframes.

However, given that the current autocomplete module (AutofillProfileAutoComplete.sys.mjs)
still requires per-process state, I added updateActiveAutofillChild so we don't have to
change how AutofillProfileAutoComplete.sys.mjs is implemented in this patch.

Depends on D203765

Comment 3

[Dimi Lee [:dimi]]

Attachment: Bug 1883909 - P3. Workaround to support detect page navigation for the same-origin iframe. r=#credential-management-reviewers

When a page navigation event is received in the top-level frame, the same-origin iframe
is able to know that because they are in the same process.

However, the plan is to remove FormAutofillContent, which means we
will not be able to use "per process" module to communicate directly.

So instead, we should solve the issue by the child talks to the parent,
and then the parent talks to its childern. But before implementing the
solution mentioned above, we still use FormAutofillContent to workaround it.

Depends on D203766

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02f7f4aac89a
P1. Remove unused variables in FormAutofillChild r=credential-management-reviewers,sgalich
https://hg.mozilla.org/integration/autoland/rev/aa8c9eb6b39b
P2. Move logic from FormAutofillContent to FormAutofillChild r=credential-management-reviewers,sgalich
https://hg.mozilla.org/integration/autoland/rev/b7875a84aa37
P3. Workaround to support detect page navigation for the same-origin iframe. r=credential-management-reviewers,jneuberger,sgalich

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/02f7f4aac89a
https://hg.mozilla.org/mozilla-central/rev/aa8c9eb6b39b
https://hg.mozilla.org/mozilla-central/rev/b7875a84aa37