1883916 - Update search-telemetry-v2 schema with a nonAdsLinkQueryParamNames property

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[James Teow [:jteow]]

In the network process, this query param is used to extract the href from a query param value to be used to connect with the href that was found on the page.

Comment 1

[James Teow [:jteow]]

Attachment: Bug 1883916 - Add nonAdsLinkQueryParamNames to search-telemetry-schema - r?standard8!

Adds a new property that will be used to extract the intended href to load on SERPs
that contain the actual URL in a query param key not known until they click on the
actual link.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f7a5399c1cc
Add nonAdsLinkQueryParamNames to search-telemetry-schema - r=Standard8

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4f7a5399c1cc

Comment 4

[James Teow [:jteow]]

Comment on attachment 9390753 [details]
Bug 1883916 - Add nonAdsLinkQueryParamNames to search-telemetry-schema - r?standard8!

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: We're planning on renaming search-telemetry-schema.json to search-telemetry-schema-v2.json to make it easier to automate certain processes in Remote Settings. We'd like to make sure that search-telemetry-schema.json is up to date on all releases before making the name change which we'd like to apply to all builds.
• User impact if declined: It could cause issues if we uplift the name change while search-telemetry-schema.json is in a different state on all platforms.
• Fix Landed on Version: 125
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It only affects browser/components/search/test/unit/test_search_telemetry_config_validation.js

Beta/Release Uplift Approval Request

• User impact if declined: We're planning on renaming search-telemetry-schema.json to search-telemetry-schema-v2.json to make it easier to automate certain processes in Remote Settings. We'd like to make sure that search-telemetry-schema.json is up to date on all releases before making the name change which we'd like to apply to all builds.

It could cause issues if we uplift the name change while search-telemetry-schema.json is in a different state on all platforms.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It only affects browser/components/search/test/unit/test_search_telemetry_config_validation.js
• String changes made/needed:
• Is Android affected?: Unknown

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9390753 [details]
Bug 1883916 - Add nonAdsLinkQueryParamNames to search-telemetry-schema - r?standard8!

Approved for 125.10esr.

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/0b37219ad4ce

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9390753 [details]
Bug 1883916 - Add nonAdsLinkQueryParamNames to search-telemetry-schema - r?standard8!

Approved for 124.0.2 dot release

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/af005a8c235a