1883932 - Inuyasha preview on Netflix causes every Firefox window to flash and go blank.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Chris Martin [:cmartin]]

Attachment: Inuyasha window flash

This report comes from my sister, but I was able to reproduce on my own machine quite easily. Here are the steps:

1. Open up a bunch of Firefox windows. Doesn't seem to matter if they're private or not, and they can be on multiple monitors.
2. Navigate to netflix.com in one of them and search for "Inuyasha".
3. Click on the Inuyasha icon to cause the preview to launch.
4. Notice that all your Firefox windows have flashed and then gone blank (it seems you can click in them to bring their contents back).

Note that, for some reason, it is specifically Inuyasha that reproduces this issue -- Both my sister and I were unable to find another Netflix preview that caused this same issue.

Note that non-Firefox windows are not affected.

Comment 1

[Ray Kraesig [:rkraesig]]

This looks like a GPU process crash — or, at least, the behavior is strikingly similar to what happens if I just kill the GPU process. Are there any crashes listed in about:crashes?

Can you reproduce this during a profiler run while using the Graphics preset on about:profiling?

(I don't have a Netflix account, so I can't easily perform the test as written.)

Comment 2

[Mayank Bansal]

Can repro.
Crash: https://crash-stats.mozilla.org/report/index/e9e9f727-b8f1-45f9-a29d-bfd2c0240307

Comment 3

[Mayank Bansal]

Attachment: about:support

Comment 4

[Mayank Bansal]

This is the regression range I got :
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1995198e0bee1b9f7d4ac3a5286fb89a8305fa28&tochange=925231a8fb5eccf055afb3e9921596d8f990128b
which seems to imply bug 1859432

Comment 5

[Mayank Bansal]

Attachment: graphics logging

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1859432

Comment 7

[Sotaro Ikeda [:sotaro]]

"Inuyasha" did not exist in Netflix in Japan. But I could reproduce the problem with a content of Bug 1705940.

Comment 8

[Sotaro Ikeda [:sotaro]]

From the followings, i am going to create a new bug for fixing the problem.

• "Inuyasha" did not exist in Netflix in Japan
• Netflix video playback with local build does not work. It causes playback error.(Bug 1763811 )

Comment 9

[Sotaro Ikeda [:sotaro]]

On Windows, 10-bit VP9 video caused the problem when video was decoded by software decoder.
And before Bug 1859432 fix, the video should cause the problem when GPU process did not exist. See esr crash

And on Linux, 10-bit VP9 video with software decoder did not cause the problem.

Implementation of batch_upload seems to have a problem.
When } else if use_batch_upload { part is disabled with local build, the video was played back without problem.

Comment 10

[Sotaro Ikeda [:sotaro]]

From comment 9, it might be better to fix WebRender batch upload.

:gw, can you comment to it?

Comment 11

[Glenn Watson [:gw]]

Attachment: Bug 1883932 - Add R16 support to texture upload pool

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52a1681d4a82
Add R16 support to texture upload pool r=sotaro,gfx-reviewers

Comment 14

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/52a1681d4a82

Comment 15

[Mayank Bansal]

This is fixed on latest Nightly for me. Thanks!

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gw, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 17

[Glenn Watson [:gw]]

Sotaro, do you think this is important to uplift to beta?

Comment 18

[Dianna Smith [:diannaS]]

FYI there are no more betas so it would have to be important enough to uplift to an RC respin (if there is one) or a planned dot release.

Comment 19

[Sotaro Ikeda [:sotaro]]

(In reply to Glenn Watson [:gw] from comment #17)

Sotaro, do you think this is important to uplift to beta?

The number of crashes are not high. But the crash happens with the specific STR of Netflix. Then I think it is important enough to uplift.

:jrmuizel, how do you think?

Comment 20

[Glenn Watson [:gw]]

Attachment: Bug 1883932 - Add R16 support to texture upload pool

Original Revision: https://phabricator.services.mozilla.com/D203973

Comment 21

[Phabricator Automation]

Uplift Approval Request

• Steps to reproduce for manual QE testing: Per bug report
• User impact if declined: GPU process crashes on some video on popular sites such as Netflix
• Fix verified in Nightly: yes
• Is Android affected?: yes
• String changes made/needed: None
• Needs manual QE test: yes
• Explanation of risk level: Minor patch, has been in nightly for a while
• Code covered by automated testing: no
• Risk associated with taking this patch: Low

Comment 22

[Alexandru Trif, Desktop Test Engineering [:atrif]]

I tried reproducing the issue with Firefox 124.0RC1 and Firefox 125.0a1 (2024-03-06) on two different Windows 10x64 machines by following the steps from comment 0 but without any luck. I have also tried the steps on an affected build on macOS 12 and Ubuntu 23.10 but the issue could no be reproduced. Just to be safe I have also verified that the issue is not reproducing with Firefox 125.0a1 (2024-03-12) on Windows 10x64 and macOS 12 by hovering over the Inuyasha title or playing it. Note that a US VPN was used to see the Inuyasha Netflix title since it seems that is not available in Romania.

Could one of you confirm whether the problem has been resolved by using the most recent nightly build? Thank you in advance!

Comment 23

[Mayank Bansal]

(In reply to Alexandru Trif, Desktop QA [:atrif] from comment #22)

I tried reproducing the issue with Firefox 124.0RC1 and Firefox 125.0a1 (2024-03-06) on two different Windows 10x64 machines by following the steps from comment 0 but without any luck. I have also tried the steps on an affected build on macOS 12 and Ubuntu 23.10 but the issue could no be reproduced. Just to be safe I have also verified that the issue is not reproducing with Firefox 125.0a1 (2024-03-12) on Windows 10x64 and macOS 12 by hovering over the Inuyasha title or playing it. Note that a US VPN was used to see the Inuyasha Netflix title since it seems that is not available in Romania.

Could one of you confirm whether the problem has been resolved by using the most recent nightly build? Thank you in advance!

I confirmed fixed on Nightly in comment #15.

Comment 24

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Oh sorry, I somehow missed that comment. Setting this as verified for Firefox 125 based on comment 15 and dropping the qe+ flag since we could not reproduce the issue. Thank you!

Comment 25

[Bob Hood [:bhood]]

Chris, can you post a screen shot of the issue? The video won't play for me.

Comment 26

[Chris Martin [:cmartin]]

Attachment: Right Before Preview.png

I have attached a screenshot of what Netflix looks like immediately before it tries to play the preview

Comment 27

[Chris Martin [:cmartin]]

Attachment: First Preview Frame.png

And then this is what happens when FF tries to draw the first frame of the preview.

Comment 28

[Chris Martin [:cmartin]]

Attachment: Inuyasha window flash

Bob Hood - I was also not able to play it back for some reason through Firefox, even though it plays fine using VLC Media Player on my machine.

I re-uploaded it after running it through FFMpeg to clean up the file format. Seems to work now.

Comment 29

[Dianna Smith [:diannaS]]

Comment on attachment 9390672 [details]
Bug 1883932 - Add R16 support to texture upload pool

requesting NI for the conflict on the release patch

Comment 30

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/2718fafaf6b2

Comment 31

[Dianna Smith [:diannaS]]

Comment on attachment 9390055 [details]
Bug 1883932 - Add R16 support to texture upload pool

Approved for 124.0.2 dot release

Comment 32

[Glenn Watson [:gw]]

Dianna has resolved the conflict in this patch.

Comment 33

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello! Would one of you mind trying again with Firefox 124.0.2 to see if the issue is fixed? Thank you both in advance!

Comment 34

[Jeff Muizelaar [:jrmuizel]]

Glenn, should we consider uplifting this to ESR as well?

Comment 35

[Glenn Watson [:gw]]

Yes, probably worth doing. Dianna, do you need a new request made for that?

Comment 36

[Dianna Smith [:diannaS]]

Yes it would need a new uplift request for esr (prob a rebased patch)
(Marking esr as affected based on comment 9)

Comment 37

[Chris Martin [:cmartin]]

(In reply to Alexandru Trif, Desktop QA [:atrif] from comment #33)

Hello! Would one of you mind trying again with Firefox 124.0.2 to see if the issue is fixed? Thank you both in advance!

I can confirm that the bug is fixed in 124.0.2.

Comment 38

[Glenn Watson [:gw]]

Attachment: Bug 1883932 - Add R16 support to texture upload pool

Original Revision: https://phabricator.services.mozilla.com/D203973

Comment 39

[Phabricator Automation]

esr115 Uplift Approval Request

• User impact if declined: Crashes on certain video formats on Netflix etc
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Per bug report
• Risk associated with taking this patch: Low
• Explanation of risk level: Has been in nightly and release for a while
• String changes made/needed: None
• Is Android affected?: yes

Comment 40

[Glenn Watson [:gw]]

Added a patch rebased on esr115 branch and requested uplift.

Comment 41

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/e941114698b0

Comment 42

[Mihai Boldan, Desktop QA [:mboldan]]

Hello! Could you also please verify the fix on Firefox ESR 115.10? Thank you!

Comment 43

[Chris Martin [:cmartin]]

Confirmed. The fix works on ESR 115.10.