1884026 - media/libcubeb/test/test_duplex.cpp:224:37: error: use of undeclared identifier 'EXPECT_DEATH'

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Mike Hommey [:glandium]]

When building gtests with --enable-project=mobile/ios --enable-warnings-as-errors:

 0:01.53 /tmp/gecko-ios/media/libcubeb/test/test_duplex.cpp:224:37: error: use of undeclared identifier 'EXPECT_DEATH'
 0:01.53   224 |       ctx, [](cubeb * p) noexcept { EXPECT_DEATH(cubeb_destroy(p), ""); });
 0:01.53       |                                     ^
 0:02.10 1 error generated.
 0:02.63 /tmp/gecko-ios/dom/media/gtest/TestMediaUtils.cpp:211:24: error: no member named 'ExitedWithCode' in namespace 'testing'
 0:02.63   211 |               testing::ExitedWithCode(0), "");
 0:02.63       |               ~~~~~~~~~^
 0:02.64 /tmp/gecko-ios/dom/media/gtest/TestMediaUtils.cpp:217:24: error: no member named 'ExitedWithCode' in namespace 'testing'
 0:02.64   217 |               testing::ExitedWithCode(0), "");
 0:02.65       |               ~~~~~~~~~^
 0:02.66 /tmp/gecko-ios/dom/media/gtest/TestMediaUtils.cpp:223:24: error: no member named 'ExitedWithCode' in namespace 'testing'
 0:02.66   223 |               testing::ExitedWithCode(0), "");
 0:02.66       |               ~~~~~~~~~^
 0:02.68 /tmp/gecko-ios/dom/media/gtest/TestMediaUtils.cpp:229:24: error: no member named 'ExitedWithCode' in namespace 'testing'
 0:02.68   229 |               testing::ExitedWithCode(0), "");
 0:02.68       |               ~~~~~~~~~^
 0:02.70 /tmp/gecko-ios/dom/media/gtest/TestMediaUtils.cpp:235:24: error: no member named 'ExitedWithCode' in namespace 'testing'
 0:02.70   235 |               testing::ExitedWithCode(0), "");
 0:02.70       |               ~~~~~~~~~^

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1884026 - Don't build death tests on platforms that don't support them.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6504c3962b09
Don't build death tests on platforms that don't support them. r=media-playback-reviewers,cubeb-reviewers,padenot

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6504c3962b09