1884053 - ld64.lld: error: undefined symbol: mozilla::baseprofiler::detail::GetThreadRegistrationTime()

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Mike Hommey [:glandium]]

When building gtests with either --enable-project=mobile/ios or --disable-gecko-profiler:

 0:47.01 ld64.lld: error: undefined symbol: mozilla::baseprofiler::detail::GetThreadRegistrationTime()
 0:47.01 >>> referenced by ../../../tools/profiler/tests/gtest/Unified_cpp_tests_gtest0.o:(symbol GeckoProfiler_ThreadRegistrationInfo_Test::TestBody()+0x6b0)
 0:47.01 >>> referenced by ../../../tools/profiler/tests/gtest/Unified_cpp_tests_gtest0.o:(symbol mozilla::profiler::ThreadRegistrationInfo::ThreadRegistrationInfo(char const*)+0xb4)
 0:47.02 >>> referenced by ../../../tools/profiler/tests/gtest/Unified_cpp_tests_gtest0.o:(symbol mozilla::profiler::ThreadRegistrationInfo::ThreadRegistrationInfo(char const*)+0x4c)

On Linux, the build doesn't fail, but it crashes when running gtests because of the same missing symbol.

I'm not sure why the non-gtest libxul doesn't fail to link in the same way on mac.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1884053 - Don't use baseprofiler::detail::GetThreadRegistrationTime when the profiler is disabled.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b09474764fb5
Don't use baseprofiler::detail::GetThreadRegistrationTime when the profiler is disabled. r=profiler-reviewers,mstange

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b09474764fb5