1884148 - Ship the Atomics.waitAsync proposal

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Dan Minor [:dminor]]

This is to track shipping the Atomics.waitAsync proposal once it's been implemented.

Comment 1

[Dan Minor [:dminor]]

This just landed in Firefox 140, we should wait a few releases before shipping.

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1884148 - Ship the Atomics.waitAsync proposal; r=mgaudet

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6aededf679b4
https://hg.mozilla.org/integration/autoland/rev/c6ff1cc3f546
Ship the Atomics.waitAsync proposal; r=mgaudet

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2e7f7f9a115c
https://hg.mozilla.org/integration/autoland/rev/b5ae55d36d5d
Revert "Bug 1884148 - Ship the Atomics.waitAsync proposal; r=mgaudet" for causing wpt failures on atomics-wait-async.https.any.html

Comment 5

[Cristina Horotan [:chorotan]]

Backed out for causing wpt failures

Backout link

Push with failures

Failure log

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1884148 - Handle eJSTimeout in GetTimeoutReasonString and update wpt expectations; r=#dom-worker-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/02398b2a9df2
https://hg.mozilla.org/integration/autoland/rev/88733272919b
Ship the Atomics.waitAsync proposal; r=mgaudet
https://github.com/mozilla-firefox/firefox/commit/50f7910d8a67
https://hg.mozilla.org/integration/autoland/rev/f01333062904
Handle eJSTimeout in GetTimeoutReasonString and update wpt expectations; r=dom-worker-reviewers,asuth

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0f6d18cdcce6
https://hg.mozilla.org/integration/autoland/rev/b19bd9e4f248
Revert "Bug 1884148 - Handle eJSTimeout in GetTimeoutReasonString and update wpt expectations; r=dom-worker-reviewers,asuth" for causing wpt failures on Mutex_posix.cpp

Comment 9

[Cristina Horotan [:chorotan]]

Backed out for causing wpt failures

Backout link

Push with failures

Failure log

Comment 10

[Dan Minor [:dminor]]

I've filed Bug 1980271 to investigate the tsan failure, I see Atomics.waitAsync on the stack, so it's quite possibly a bug in our implementation.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5a5a85d43a90
https://hg.mozilla.org/integration/autoland/rev/0ec72c6b449b
Ship the Atomics.waitAsync proposal; r=mgaudet
https://github.com/mozilla-firefox/firefox/commit/4b06e22dccc5
https://hg.mozilla.org/integration/autoland/rev/d444468e3697
Handle eJSTimeout in GetTimeoutReasonString and update wpt expectations; r=dom-worker-reviewers,asuth

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0df3b92e27d9
https://hg.mozilla.org/integration/autoland/rev/fd9ad3129f48
Revert "Bug 1884148 - Handle eJSTimeout in GetTimeoutReasonString and update wpt expectations; r=dom-worker-reviewers,asuth" for causing wpt failures @ integration-with-the-javascript-agent-formalism/atomics-wait-async.https.any.worker.html

Comment 13

[amarc]

Backed out for causing wpt failures @ integration-with-the-javascript-agent-formalism/atomics-wait-async.https.any.worker.html

• Backout link
• Push with failures
• Failure Log

Comment 14

[Iain Ireland [:iain]]

Ugh, this is similar to bug 1980271.

Opened bug 1984739.

Comment 15

[Dan Minor [:dminor]]

Thanks for having a look Iain :)

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/42652110128d
https://hg.mozilla.org/integration/autoland/rev/500012d692f7
Ship the Atomics.waitAsync proposal; r=mgaudet
https://github.com/mozilla-firefox/firefox/commit/d725d7582b64
https://hg.mozilla.org/integration/autoland/rev/13619275703e
Handle eJSTimeout in GetTimeoutReasonString and update wpt expectations; r=dom-worker-reviewers,asuth

Comment 17

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/500012d692f7
https://hg.mozilla.org/mozilla-central/rev/13619275703e

Comment 18

[Pascal Chevrel:pascalc]

Should that be included in our 145 release notes? Thanks

Comment 19

[Dan Minor [:dminor]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Adds support for Atomics.waitAsync, which is implemented in Safari and Chromium, and has caused webcompat problems for us.
[Affects Firefox for Android]: Yes
[Suggested wording]: Support has been added for the Atomics.waitAsync proposal, which is a non-blocking, asynchronous version of Atomics.wait. This allow synchronization of threads based upon the value in a shared memory location, for more details please see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Atomics/waitAsync.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Atomics/waitAsync

Comment 20

[Pascal Chevrel:pascalc]

Thanks, note added to our 145 nIghtly release notes. I am keeping the relnote? tracking flag open until we ship 145 and integrate this note into our final release notes.

Comment 21

[Hamish Willee]

FF145 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/41498

Comment 22

[Pascal Chevrel:pascalc]

Added to our final 145 release notes.