1884150 - Ship Resizable and growable ArrayBuffers

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Dan Minor [:dminor]]

Once we've had some experience with resizeable and growable arraybuffers on Nightly, and it's been adequately fuzz tested, we'll want to ship it.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

FWIW, I ran into the lack of ArrayBuffer.resize on https://huggingface.co/TheBloke/Mixtral-8x7B-v0.1-GGUF?show_tensors=mixtral-8x7b-v0.1.Q2_K.gguf

Comment 2

[Dan Minor [:dminor]]

Anba, how do you feel about letting this ride the trains?

Comment 3

[André Bargull [:anba]]

I think we should first talk to the fuzzing team to ensure we had proper fuzzing. JIT support landed about a month ago (bug 1842999) and fuzzing was enabled ~2 months ago (bug 1878657).

Comment 4

[Dan Minor [:dminor]]

I'm planning to ship this in Firefox 128.

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1884150 - Ship growable and resizeable ArrayBuffers; r=sfink!

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1884150 - Update text_xrayToJS.html expectations; r=peterv!

Depends on D210708

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ccbb1c07dd0
Ship growable and resizeable ArrayBuffers; r=sfink
https://hg.mozilla.org/integration/autoland/rev/38da6a39cdfb
Update text_xrayToJS.html expectations; r=peterv
https://hg.mozilla.org/integration/autoland/rev/200236dbbb29
apply code formatting via Lando

Comment 8

[Serban Stanca [:SerbanS]]

Backed out for causing multiple wpt failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-PASS | /html/infrastructure/safe-passing-of-structured-data/cross-origin-transfer-resizable-arraybuffer.html | postMessaging resizable ArrayBuffer to OOPIF - expected FAIL

Please also be aware about:
These wpt failures
Failure Log

These wpt failures
Failure Log

These wpt failures
Failure Log

Comment 9

[Dan Minor [:dminor]]

Thanks for the links. I have a try run here, https://treeherder.mozilla.org/jobs?repo=try&revision=144a9d09dc2917eb069b096048084bbf46d8f66d. I initially missed the failures in wpt22, but I've pulled the manifest updates into my latest patch.

Comment 10

[Dan Minor [:dminor]]

Attachment: Bug 1884150 - Update wpt test expectations; r=sfink!

Depends on D210709

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/641a1d71cfa8
Ship growable and resizeable ArrayBuffers; r=sfink
https://hg.mozilla.org/integration/autoland/rev/fa3320a5ebc0
Update text_xrayToJS.html expectations; r=peterv
https://hg.mozilla.org/integration/autoland/rev/71009f63ff4f
Update wpt test expectations; r=sfink

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/641a1d71cfa8
https://hg.mozilla.org/mozilla-central/rev/fa3320a5ebc0
https://hg.mozilla.org/mozilla-central/rev/71009f63ff4f

Comment 13

[Tom S]

Would you consider requesting a release note for this?

Comment 14

[Dan Minor [:dminor]]

Release Note Request
[Why is this notable]: This enables Resizeable and Growable ArrayBuffers in SpiderMonkey. Both V8 and JavaScriptCore have already shipped their implementations.
[Affects Firefox for Android]: Yes.
[Suggested wording]: Resizeable ArrayBuffers and Growable SharedArrayBuffers are now supported in SpiderMonkey. This allows the size of an ArrayBuffer to be changed without having to allocate a new buffer and copy data into it. For more information, see the MDN documentation.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer/resize, https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer/grow.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx128 relnotes.

Comment 16

[Hamish Willee]

FYI FF128 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/33983. Compatibility data and MDN release note are main changes - the docs themselves already look good. I've marked as "dev-doc-complete" while waiting for reviews to go through.