Closed Bug 1884150 Opened 4 months ago Closed 1 month ago

Ship Resizable and growable ArrayBuffers

Categories

(Core :: JavaScript Engine, task, P2)

task

Tracking

()

RESOLVED FIXED
128 Branch
Tracking Status
relnote-firefox --- 128+
firefox128 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

(Blocks 2 open bugs)

Details

(Keywords: dev-doc-complete)

Attachments

(3 files)

Once we've had some experience with resizeable and growable arraybuffers on Nightly, and it's been adequately fuzz tested, we'll want to ship it.

Severity: -- → N/A
Priority: -- → P2
Keywords: dev-doc-needed

Anba, how do you feel about letting this ride the trains?

Flags: needinfo?(andrebargull)

I think we should first talk to the fuzzing team to ensure we had proper fuzzing. JIT support landed about a month ago (bug 1842999) and fuzzing was enabled ~2 months ago (bug 1878657).

Flags: needinfo?(andrebargull)
Assignee: nobody → dminor

I'm planning to ship this in Firefox 128.

Status: NEW → ASSIGNED
Blocks: 1897249
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5ccbb1c07dd0
Ship growable and resizeable ArrayBuffers; r=sfink
https://hg.mozilla.org/integration/autoland/rev/38da6a39cdfb
Update text_xrayToJS.html expectations; r=peterv
https://hg.mozilla.org/integration/autoland/rev/200236dbbb29
apply code formatting via Lando

Backed out for causing multiple wpt failures.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-PASS | /html/infrastructure/safe-passing-of-structured-data/cross-origin-transfer-resizable-arraybuffer.html | postMessaging resizable ArrayBuffer to OOPIF - expected FAIL

Please also be aware about:
These wpt failures
Failure Log

These wpt failures
Failure Log

These wpt failures
Failure Log

Flags: needinfo?(dminor)

Thanks for the links. I have a try run here, https://treeherder.mozilla.org/jobs?repo=try&revision=144a9d09dc2917eb069b096048084bbf46d8f66d. I initially missed the failures in wpt22, but I've pulled the manifest updates into my latest patch.

Flags: needinfo?(dminor)

Depends on D210709

Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/641a1d71cfa8
Ship growable and resizeable ArrayBuffers; r=sfink
https://hg.mozilla.org/integration/autoland/rev/fa3320a5ebc0
Update text_xrayToJS.html expectations; r=peterv
https://hg.mozilla.org/integration/autoland/rev/71009f63ff4f
Update wpt test expectations; r=sfink
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch

Would you consider requesting a release note for this?

Flags: needinfo?(dminor)

Release Note Request
[Why is this notable]: This enables Resizeable and Growable ArrayBuffers in SpiderMonkey. Both V8 and JavaScriptCore have already shipped their implementations.
[Affects Firefox for Android]: Yes.
[Suggested wording]: Resizeable ArrayBuffers and Growable SharedArrayBuffers are now supported in SpiderMonkey. This allows the size of an ArrayBuffer to be changed without having to allocate a new buffer and copy data into it. For more information, see the MDN documentation.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer/resize, https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer/grow.

relnote-firefox: --- → ?
Flags: needinfo?(dminor)

Added to the Fx128 relnotes.

FYI FF128 MDN docs work for this can be tracked in https://github.com/mdn/content/issues/33983. Compatibility data and MDN release note are main changes - the docs themselves already look good. I've marked as "dev-doc-complete" while waiting for reviews to go through.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: