1884170 - Options button fxview-tab-row-secondary-button on Firefox View History search results page is missing an icon

Status: RESOLVED FIXED

(Firefox :: Firefox View, defect)

Description

[Anna Yeddi [:ayeddi]]

Attachment: Firefox View History search results page with one of Option buttons hovered (with and without HCM on macOS).png

STR:

1. Open Firefox View > History tab
2. Enter a search query to get taps filtered
3. Observe the far right side of each tab row - the Options button for a row
4. Hover over the Options button for a row
5. Repeat steps above with High Contrast Mode enabled/disabled

Expected:

1. the Options button for a row has a clearly visible icon, i.e. ..., that communicates the purpose of this control.
2. This button looks as an icon button with and without HCM, by default, while hovered and/or focused

Actual:

1. the Options button for a row is unlabeled and, no visual indication is provided for the button or its states, especially when no HCM is activated

Comment 2

[Nikki Sharpley (:nikkis) (she/her)]

Attachment: Bug 1884170 - Missing options button icon in history fixed r=#fxview-reviewers

Added correct secondary class names to show options button icon in history.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d984b2868ec
Missing options button icon in history fixed r=fxview-reviewers,kcochrane

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/9d984b2868ec