1884172 - Can't paste a screenshot into Slack

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect)

Description

[Andrew Overholt [:overholt]]

For a Nightly or two (I can use mozregression if it'll help), I can't paste a screenshot captured using Firefox's screenshot tool into Slack. It was pointed out to me that bug 1789727 recently landed so perhaps this is a regression from that? I'm also told this works on Windows but it doesn't work on my Mac.

Comment 1

[Andrew Overholt [:overholt]]

FWIW I can verify the screenshot content is on the clipboard.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1789727

Comment 3

[Niklas Baumgardner [:niklas]]

Thanks for filing this!
I was not able to reproduce this on Windows. I don't have access to my mac right now so I'm unable to test this.
Does this happen on the slack app or site? or both?

Comment 4

[Andrew Overholt [:overholt]]

(In reply to Niklas Baumgardner [:niklas] from comment #3)

Does this happen on the slack app or site? or both?

Slack.com (site) I don't have the app installed but I can if you'd like.

Comment 5

[Simona Badau, Desktop QA, PTO 13-25aug]

I can also reproduce this issue on macOS 13 using the latest Nightly 125.0a1. When I try to paste a copied screenshot in slack.com (also loaded in Nightly), it does not work.

However, I'm not encountering any issues when pasting the screenshot into the Slack app or the website version using a different browser.

The issue is not reproducible using the latest Nightly 125.0a1 on Ubuntu 22.04.

Comment 6

[Andrew Overholt [:overholt]]

I ran mozregression and ran into many builds that had tab crashes with slack.com. It looks like it started failing some time between 2024-03-04 and 2024-03-05 and mozregression pointed me specifically at bug 1847358. Tom, do you think part 3 of your work in https://phabricator.services.mozilla.com/D203380 could be responsible for the regression here?

Comment 7

[Thomas Wisniewski [:twisniewski]]

I doubt it, as I'm not sure why my patch would cause a difference. If I take a look at event.clipboardData.items[0] on a paste event after taking a screenshot, which Slack should be doing if I'm reading their minified code correctly, then I do see what I would expect: DataTransferItem { kind: "file", type: "image/png" }. The screenshot also looks fine when I paste it into another app, so I don't see why my code would affect it.

But I suppose we could always revert that patch and see what happens?

Comment 8

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1884172 - Use x-moz-nativeimage when copying screenshots to clipboard. r=mconley

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a24a00e9a529
Use x-moz-nativeimage when copying screenshots to clipboard. r=mconley

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a24a00e9a529

Comment 11

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser/components/screenshots/tests/browser/browser_screenshots_test_full_page.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/593c67f1319e000090ce5f2958ef7870a60dda39

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/screenshots/tests/browser/browser_screenshots_test_full_page.js | R color value - false == true

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1789727

Comment 13

[Serban Stanca [:SerbanS]]

Backout merged in central: https://hg.mozilla.org/mozilla-central/rev/593c67f1319e000090ce5f2958ef7870a60dda39

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e8ffb360c27
Use x-moz-nativeimage when copying screenshots to clipboard. r=mconley

Comment 15

[Serban Stanca [:SerbanS]]

Backed out for causing OSX mochitests failures in browser_screenshots_test_visible.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/screenshots/tests/browser/browser_screenshots_test_visible.js | R color value - 111 == 130 - {"filename":"chrome://mochitests/content/browser/browser/components/screenshots/tests/browser/browser_screenshots_test_visible.js","name":"test_visibleScreenshot/<","sourceId":882,"lineNumber":69,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"resource://testing-common/BrowserTestU

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7250823eff5f
Use x-moz-nativeimage when copying screenshots to clipboard. r=mconley

Comment 17

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7250823eff5f

Comment 18

[Simona Badau, Desktop QA, PTO 13-25aug]

Verified as fixed using the latest Nightly 125.0a (Build ID: 20240314092545) on macOS 13, Ubuntu 22.04 and Windows 10 x64.