1884243 - [wayland] Dragging multiple selected tabs out of the tab bar does not create a new window for most drop locations

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[moritz1000]

Attachment: drag_drop_tabs_firefox.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:123.0) Gecko/20100101 Firefox/123.0

Steps to reproduce:

1. Use Linux + Wayland
2. Shift mouse click to select several tabs
3. Hold left mouse click and drag the tabs towards the center of the current Firefox window.

Actual results:

Nothing happens.
When releasing left mouse click the tabs just return/stay where they were before, in the same Firefox Window

Expected results:

Firefox should have spawned a new window with the selected tabs.

ADDITIONAL INFORMATION:

1. drag and drop of only one tab inside the Firefox window works in Wayland: a new Firefox window spawns
2. drag and drop of several tabs while moving them OUTSIDE of the Firefox window (so towards empty space) does work in Wayland: a new Firefox window spawns with the selected tabs
3. On X11 drag and drop of several tabs worked in both cases: moving the selected tabs outside of the Firefox window / moving them inside of Firefox

Comment 1

[moritz1000]

Attachment: drag_drop_tabs_firefox.mkv

A short video showcasing the bug on Linux / Wayland:

1. drag & drop SEVERAL tabs inside Firefox: does NOT work
2. drag & drop ONE tabs inside Firefox: does work
3. drag & drop SEVERAL tabs outside Firefox: does work

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Kestrel]

(In reply to moritz1000 from comment #0)

2. drag and drop of several tabs while moving them OUTSIDE of the Firefox window (so towards empty space) does work in Wayland: a new Firefox window spawns with the selected tabs

Dragging multiple selected tabs does not create a new window for me when dropping outside the window with Nightly 127.0a1 (2024-04-28) on Ubuntu 24.04 (Wayland). It works with XWayland when dropped both inside and outside the window.

There are a few small areas where it works, dropping slightly below the address bar, below the bookmarks bar or above the tab bar successfully creates a new window.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

It's because "application/x-moz-internal-item-list" mime is used for multiple tab drop.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1884243 [Wayland] Flip GTK_DRAG_RESULT_ERROR to GTK_DRAG_RESULT_NO_TARGET on Wayland as Gecko expects it r?emilio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/711437c375a2
[Wayland] Flip GTK_DRAG_RESULT_ERROR to GTK_DRAG_RESULT_NO_TARGET on Wayland as Gecko expects it r=emilio

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/711437c375a2