1884293 - Disable PHC on aarch64 release channel

Status: RESOLVED FIXED

(Core :: Memory Allocator, task)

Description

[Paul Bone [:pbone]]

We want to roll out PHC to more desktops, but let's exclude aarch64 for now because it has a performance problem (Bug 1874022). PHC will still be enabled for Nightly on aarch64.

Comment 1

[Paul Bone [:pbone]]

Attachment: Bug 1884293 - Disable PHC on aarch64 release channel r=gcp

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe38c21e5d5b
Disable PHC on aarch64 release channel r=gcp

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/fe38c21e5d5b

Comment 4

[Paul Bone [:pbone]]

Attachment: Bug 1884293 - Disable PHC on aarch64 release channel

Original Revision: https://phabricator.services.mozilla.com/D203997

Comment 5

[Phabricator Automation]

Uplift Approval Request

• Code covered by automated testing: yes
• Risk associated with taking this patch: Low risk
• Needs manual QE test: no
• Explanation of risk level: Change is to build settings only and will disable the PHC configuration for aarch64 builds in Late beta or later.
• Is Android affected?: no
• String changes made/needed: None
• Fix verified in Nightly: no
• User impact if declined: Delay in PHC rollout. We'd like to roll out PHC to 100% of the x86_64 desktop population, but we need to disable it for aarch64 first.
• Steps to reproduce for manual QE testing: None

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9390668 [details]
Bug 1884293 - Disable PHC on aarch64 release channel

we are out of betas but leaving open in case of an RC respin or for the planned dot release

Comment 7

[Paul Bone [:pbone]]

Comment on attachment 9390668 [details]
Bug 1884293 - Disable PHC on aarch64 release channel

Hi Dianna, I want to cancel the uplift request. Is removing the ? from approval-mozilla-release enough?

Thanks.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 9

[Dianna Smith [:diannaS]]

Yes, you should also abandon any extra phab revision. I just did this now, so you're all set!