1884386 - Disable taskgraph-diff task to reduce load on hg.mozilla.org

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[[e-mail] (:bhearsum)]

We currently do this as part of task generation, which means it happens anytime ./mach taskgraph runs, regardless of whether or not any relevant files have changed. We can avoid this by having it done when a ./mach taskgraph --diff task is actually running.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: Bug 1884386: don't hit hg.mozilla.org to find base revision for taskgraph --diff until runtime r?ahal!

We currently hit hg.mozilla.org virtually anytime ./mach taskgraph is used, even though this task doesn't run most of the time, and thus the data we fetch for it is pointless. Let's discover this information at runtime instead.

(An alternative I considered was to move this call to a morph, but that seemed like it was more work and less discoverable.)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6b0c0cbab82
don't hit hg.mozilla.org to find base revision for taskgraph --diff until runtime r=ahal,taskgraph-reviewers

Comment 3

[[e-mail] (:bhearsum)]

Attachment: Bug 1884386: load parameters file before trying to access parameters in taskgraph --diff r?ahal!

This is a pretty crappy hack to workaround an error that https://phabricator.services.mozilla.com/D204046 introduced.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed837d0b34ab
load parameters file before trying to access parameters in taskgraph --diff r=ahal,taskgraph-reviewers

Comment 5

[[e-mail] (:bhearsum)]

Attachment: Bug 1884386: Revert D204065 and D204046 r?ahal!

These ended up using the wrong value for base_ref for taskgraph-diff jobs.

Comment 6

[[e-mail] (:bhearsum)]

Attachment: Bug 1884386: Disable taskgraph-diff task for now to reduce load on hg.mozilla.org r?ahal!

Depends on D204085

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f6463e81d9f
Revert D204065 and D204046 r=ahal,taskgraph-reviewers
https://hg.mozilla.org/integration/autoland/rev/49047047215d
Disable taskgraph-diff task for now to reduce load on hg.mozilla.org r=ahal,taskgraph-reviewers

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/c6b0c0cbab82
https://hg.mozilla.org/mozilla-central/rev/ed837d0b34ab
https://hg.mozilla.org/mozilla-central/rev/5f6463e81d9f
https://hg.mozilla.org/mozilla-central/rev/49047047215d

Comment 9

[Julien Cristau [:jcristau]]

Retitling to make it clear what actually landed.