1884393 - [toolbar redesign] Make sure keyboard animates correctly when focusing on the toolbar

Status: NEW

(Fenix :: Toolbar, task, P3)

Description

[Roger Yang [:royang]]

This is related to https://bugzilla.mozilla.org/show_bug.cgi?id=1821706. Since we're redesigning the toolbar, we want to make sure that this issue doesn't occur after switching over to the new design.

Comment 1

[Chris Peterson [:cpeterson]]

Setting "enhancement" and "task" bug types to Severity N/A.

Comment 2

[Chris Peterson [:cpeterson]]

Setting toolbar redesign's Release blockers to priority P3 until we finish fixing our Beta experiment blockers.

Comment 3

[Joe M [:jmahon]]

We improved the animation for the previous Toolbar design (in Bug 1821706), but not completely; but with the redesign, the doubly-high address bar / nav bar exacerbate the janky behavior, so we might need to revisit this.

However, improving the animation might require some more fundamental improvements than simple animation changes.

Comment 4

[Joe M [:jmahon]]

Planning poker notes:

• If we try to fix what Verdi was pointing out, this would be pretty big and could be broken down: we want one element, we would have to remove the dialog fragment, and not switch between a fake one and a real one.
• But just fixing the keyboard in the scope of the toolbar might be easier.

Summary:
This issue falls into the category of "too many unknowns to estimate": we need to re-review what was changed as part of Bug 1821706, and do a spike to determine how we would go about doing this (record a slowmo video; determine whether it would be possible to create a manual animation for the toolbar to sync up with the keyboard animation without fully rewriting everything in Compose; or consider any other possible improvement to reduce the user-perceivable jank)

Comment 5

[Roger Yang [:royang]]

Attachment: Screen_recording_20240709_161448.webm

Attached recording of keyboard animation with navigation toolbar (toolbar redesign phase 1) from emulator. From the video, the animation is much smoother and does not have the 2nd address bar issue.

The only issue left is the small time gap between the toolbar moving up and the keyboard showing up under it.

Comment 6

[Roger Yang [:royang]]

Attachment: Screen_recording_20240709_180305.mp4

Latest video with more frames and heavier website (mlb.com) shows that there is still a 2nd toolbar before the keyboard animation.

Comment 7

[Roger Yang [:royang]]

Attachment: Screen_recording_20240709_180846.mp4

With navigation bar enabled, the original address bar fades away and then after keyboard pops up the new address bar then fades in.