1884470 - Crash in [@ mozilla::StaticPrefs::network_http_sendRefererHeader_DoNotUseDirectly]

Status: RESOLVED DUPLICATE of bug 1883868

(Core :: Graphics: Text, defect)

Description

[BugBot [:suhaib / :marco]]

Crash report: https://crash-stats.mozilla.org/report/index/b4f7b707-dcb9-4388-bef4-d940b0240306

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(IsAtomic<uint32_t>::value || NS_IsMainThread()) (Non-atomic static pref 'network.http.sendRefererHeader' being accessed on background thread by getter)

Top 10 frames of crashing thread:

0  xul.dll  mozilla::StaticPrefs::network_http_sendRefererHeader_DoNotUseDirectly  modules/libpref/init/StaticPrefList_network.h:262
0  xul.dll  mozilla::dom::ReferrerInfo::GetUserReferrerSendingPolicy  dom/security/ReferrerInfo.cpp:185
0  xul.dll  mozilla::dom::ReferrerInfo::HandleUserReferrerSendingPolicy const  dom/security/ReferrerInfo.cpp:487
0  xul.dll  mozilla::dom::ReferrerInfo::ComputeReferrer  dom/security/ReferrerInfo.cpp:1350
0  xul.dll  mozilla::net::HttpBaseChannel::SetReferrerInfoInternal  netwerk/protocol/http/HttpBaseChannel.cpp:1895
1  xul.dll  mozilla::net::HttpBaseChannel::SetReferrerInfo  netwerk/protocol/http/HttpBaseChannel.cpp:1899
2  xul.dll  mozilla::FontLoaderUtils::BuildChannelSetup  layout/style/FontLoaderUtils.cpp:62
3  xul.dll  mozilla::FontLoaderUtils::BuildChannel  layout/style/FontLoaderUtils.cpp:177
4  xul.dll  mozilla::dom::FontFaceSetWorkerImpl::StartLoad  layout/style/FontFaceSetWorkerImpl.cpp:259
5  xul.dll  gfxUserFontEntry::DoLoadNextSrc  gfx/thebes/gfxUserFontSet.cpp:572

By querying Nightly crashes reported within the last 2 months, here are some insights about the signature:

• First crash report: 2024-03-06
• Process type: Content
• Is startup crash: No
• Has user comments: No
• Is null crash: Yes - 2 out of 9 crashes happened on null or near null memory address

Comment 1

[Andrew McCreight [:mccr8]]

This looks like fallout from fonts-on-worker work, though I can't tell why this suddenly started showing up a few days ago. Maybe there was a signature change?

Comment 2

[Andrew McCreight [:mccr8]]

On 2024-03-05, this started showing up, first on beta. Then a day later, it started showing up on Nightly as well.

Comment 3

[Andrew McCreight [:mccr8]]

I don't see any similar crashes showing up under other signatures.

Comment 4

[Timothy Nikkel (:tnikkel)]

Maybe similar/same as bug 1883868?

Comment 5

[Dianna Smith [:diannaS]]

I don't think this was caused by the patches in bug 1883868 as there was no beta build that included those changes (just landed on mozilla-beta) and they landed in central 2024-03-08. However, it could have the same culprit.
:emilio any thoughts on this?

Comment 6

[Emilio Cobos Álvarez [:emilio]]

I think Tim was saying that this is likely fixed by bug 1883868, and I agree, given the stack