Closed Bug 1884488 Opened 2 years ago Closed 2 years ago

Automatically switch themes when system theme changes does not work in private windows

Categories

(Firefox :: Theme, enhancement)

Firefox 123
x86_64
Linux
enhancement

Tracking

()

RESOLVED WONTFIX

People

(Reporter: kaikli, Unassigned)

References

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:123.0) Gecko/20100101 Firefox/123.0

Steps to reproduce:

Set theme to "system theme" and toogle system theme.

Actual results:

Only the theme in normal windows changes when switching the system theme. The theme of private windows sticks to the theme that was active when the first private window was opened.

Expected results:

Also switch themes in private windows.

Component: Untriaged → Theme
OS: Unspecified → Linux
Hardware: Unspecified → x86_64
Summary: Automatically switch themes in private windows does not work → Switch themes to system theme in private windows does not work
Summary: Switch themes to system theme in private windows does not work → Automatically switch themes when system theme changes does not work in private windows

Could you add an screencast? Private windows are generally forced to dark mode by design so I wonder if that's what you're seeing.

Flags: needinfo?(kaikli)

Then this is probably what I experienced.
If this is the desired behavior maybe add a short note to the theme description?

You can download the short screen recording from the following url.
https://send.tresorit.com/a#3tGCyTvUOS_egJdZQPNEyw

Flags: needinfo?(kaikli)

Yeah so I think what you're seeing is the expected behavior which is that with themes that support dark mode (which includes the system theme), private windows are dark...

Maybe the "System theme" description should mention that or something, yeah...

Flags: needinfo?(pbz)
See Also: → 1749375

Based on the previous comment this looks like intended behavior, I'm opening it as an enhancement so that maybe there's something that can be added to the system theme description.

Severity: -- → S4
Status: UNCONFIRMED → NEW
Type: defect → enhancement
Ever confirmed: true

(In reply to Simona Badau, Desktop QA from comment #4)

Based on the previous comment this looks like intended behavior,

That's correct.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX

Intended behavior indeed. Sorry for the late reply, I was OOO.
If I recall correctly, we sometimes only apply the theme changes to PBM windows when the window is reopened.

Flags: needinfo?(pbz)
You need to log in before you can comment on or make changes to this bug.