188461 - Top menus fail to drop down on mouseover.

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Athanasius]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030109
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3b) Gecko/20030109

  I last had this working with version 2002121404.  On this version when you put
the mouse over one of the top menus "News", "Games", etc. the menu drops down to
show you the entries within it.  On any version I've tried since this does not
work, trying once every 4 days or so with then-current nightly build.

  The Java Console contains a lot of griping:

Warning: reference to undefined property e.name
Source File: http://www.barrysworld.com/_functions/client/fToolbars.js
Line: 23
Warning: reference to undefined property divObj.offsetTop
Source File: http://www.barrysworld.com/_functions/clienfToolbars.js
Line: 50
Warning: reference to undefined property divObj.offsetHeight
Source File: http://www.barrysworld.com/_functions/client/fToolbars.js
Line: 51
Warning: reference to undefined property divObj.offsetLeft
Source File: http://www.barrysworld.com/_functions/client/fToolbars.js
Line: 52
Warning: reference to undefined property divObj.offsetWidth
Source File: http://www.barrysworld.com/_functions/client/fToolbars.js
Line: 53

Is the javascript trying to make use of functions/elements that are no longer
supported (once current mozilla becomes a release version), or is this something
that needs fixing?  If the former I'll give a heads up to the Barrysworld people.

Reproducible: Always

Steps to Reproduce:
1. http://www.barrysworld.com/news/default.asp
2. Move mouse over, say, the "Your Services" menu at the top
3. See it fail to have the menu drop down.

Actual Results:  
No menu dropping down.

Expected Results:  
Menu should drop down.

Comment 1

[Phil Schwartau]

Those are just warnings. I get this error when I mouseover an item:

Error: cite has no properties
Source File: http://www.barrysworld.com/_functions/client/fGlobal.js
Line: 77


I looked that file up. Looks like they've made a recent addition
to the code at the site:

/*
  Original idea : Adrian Holovaty
  http://www.holovaty.com/blog/archive/2002/12/20/0454
*/
function initQuotes() {
  if (!document.getElementsByTagName) return;

  var aQuotes = document.getElementsByTagName("blockquote");

  for (var i = 0; i < aQuotes.length; i++) {
    var cite = aQuotes[i].getAttribute("cite");
    if (cite.length) {         <<<---------------------------------- LINE 77
      var sdiv = document.createElement("div");
      sdiv.style.textAlign = "right";
      var surl = document.createElement("a");
      surl.setAttribute("href", cite);
      surl.appendChild(document.createTextNode(" source"));
      surl.title = cite;
      aQuotes[i].appendChild(sdiv.appendChild(surl));
    }
  }
}


Note they are using |cite| attribute of a <blockquote> tag.
Reassigning to the DOM experts for further analysis; this is
not a JavaScript Engine issue -

Comment 2

[Boris Zbarsky [:bzbarsky]]

Actually, the problem with the menus looks like it's due to the following code
in 	function mouseOver(evt) in the file
http://www.barrysworld.com/_functions/client/fToolbars.js :

var e= (is.ie4up)? window.event.srcElement : evt.target.parentNode; 
if (e.name=="topMenu") {

where the HTML is <a name="topMenu">Text</a>

Ever since we stopped firing mouseover at text nodes, there is no way this code
can work; the site wants to remove the .parentNode from that line....

Comment 3

[John Keiser (jkeiser)]

Haha, we have to un-evangelize them? :)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Yes.  Fun, eh?

Comment 5

[Johnny Stenback (:jst)]

Mass-reassigning bugs to [e-mail]

Comment 6

[José Jeria]

url is dead

Comment 7

[Andrew Hagen]

This bug report is very old and no longer applies. Gecko has seen many improvements since this report. URL is dead, and redirected URL http://www.game.co.uk/ does have menus that work on current trunk builds. 

Resolving WFM.