Remove unnecessary `filterStack` function from ExtensionUtils.sys.mjs
Categories
(WebExtensions :: General, task, P3)
Tracking
(firefox143 fixed)
| Tracking | Status | |
|---|---|---|
| firefox143 | --- | fixed |
People
(Reporter: standard8, Assigned: reachcmphere, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(1 file, 4 obsolete files)
The filterStack function in ExtensionUtils.sys.mjs is intended for replacing Task.jsm and Promise-backed.js in stacks with <Promise chain>. However, neither of those files now exist, so this function is no longer necessary.
|
Reporter | |
Updated•1 year ago
|
|
Assignee | |
Comment 1•6 months ago
|
||
|
|
Assignee | |
Comment 2•6 months ago
|
||
The bug explanation indicates filterStack function needs removing from file ExtensionUtils.sys.mjs, but we found that filterStack was referenced in at least 1 other location (ExtensionCommon.sys.mjs), too. The second location uses the reference in a way that seems to need some context. Should these references be replaced with something else or safely removed?
|
|
Assignee | |
Comment 4•5 months ago
|
||
|
|
Assignee | |
Comment 5•5 months ago
|
||
|
||
Updated•5 months ago
|
|
|
||
Updated•5 months ago
|
|
|
Assignee | |
Comment 6•5 months ago
|
||
Are there any tests I should run for this?
|
|
Assignee | |
Comment 7•5 months ago
|
||
|
|
||
Updated•5 months ago
|
|
|
||
Updated•5 months ago
|
|
|
||
Updated•5 months ago
|
|
|
Assignee | |
Comment 8•5 months ago
|
||
|
|
||
Comment 9•5 months ago
|
||
Comment on attachment 9500249 [details]
Bug 1884618 - Remove unnecessary filterStack function from ExtensionUtils.sys.mjs. r?willdurand!
Revision D257110 was moved to bug 1884619. Setting attachment 9500249 [details] to obsolete.
|
|
||
Updated•5 months ago
|
|
||
Comment 10•5 months ago
|
||
|
||
Comment 11•5 months ago
|
||
| bugherder | ||
|
||
Updated•3 months ago
|
Description
•