1884719 - [wmfme] ensure the hardware decoding is available before starting the media engine

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P1)

Description

[Alastor Wu [:alwu]]

We got some D3D related crashes after shortly enabling the media engine pref on Nightly in bug 1881620. I think those crashes came from machines which don't have proper hardware decoding support or have high crash rate on their graphic card, or having a buggy version of the gfx driver.

We should check gfx::gfxVars::CanUseHardwareVideoDecoding() before starting a media engine playback.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1884719 - part1 : init gfxVar when creating a UtilityAudioDecoderParent.

Move initializing gfxVar from creating a video bridge to the moment we
create UtilityAudioDecoderParent in order to ensure that we can always
get correct value from gfxVar.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1884719 - part2 : only use media engine playback when hardware video decoding is allowed.

Depends on D204292

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1884719 - part3 : make sure we always have a DXGI device manager before creating a media engine.

Depends on D204293

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1884719 - part4 : move wmfme to the gpu worker.

As now we only allow the media engine playback running if the machine is
capable for the video hardware decoding, we need to move wmfme to the
gpu worker in order to get that ability.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1884719 - part3 : add a by-pass pref for testing.

Ideally, we should run wmfme on the gpu worker in order to access
video hardware decoding. However, when switching task to the gpu
worker, there are some tests starting failed on the try server [1].

Therefore, adding this pref temporarily to bypass the gfx check until
we figure out why those tests fail on the gpu worker.

[1] https://treeherder.mozilla.org/jobs?repo=try&revision=bd9a68c7c259ba9028051c8898ddd69384616ac5&selectedTaskRun=OvNqUv77Q5OVeBDlIhWQ5g.0

Comment 6

[Phabricator Automation]

Comment on attachment 9390628 [details]
Bug 1884719 - part3 : make sure we always have a DXGI device manager before creating a media engine.

Revision D204294 was moved to bug 1885046. Setting attachment 9390628 [details] to obsolete.

Comment 7

[Phabricator Automation]

Comment on attachment 9390870 [details]
Bug 1884719 - part4 : move wmfme to the gpu worker.

Revision D204422 was moved to bug 1885046. Setting attachment 9390870 [details] to obsolete.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f715e1f7491
part1 : init gfxVar when creating a UtilityAudioDecoderParent. r=gerard-majax
https://hg.mozilla.org/integration/autoland/rev/0a98d4f122c3
part2 : only use media engine playback when hardware video decoding is allowed. r=media-playback-reviewers,jolin
https://hg.mozilla.org/integration/autoland/rev/c79195eb2291
part3 : add a by-pass pref for testing. r=media-playback-reviewers,ci-and-tooling,jmaher,padenot

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/9f715e1f7491
https://hg.mozilla.org/mozilla-central/rev/0a98d4f122c3
https://hg.mozilla.org/mozilla-central/rev/c79195eb2291

Comment 10

[Alastor Wu [:alwu]]

Wrong regression.