1884722 - Translating a specific page removes some whitespaces between words

Status: RESOLVED FIXED

(Firefox :: Translations, defect)

Description

[Marco Castelluccio [:marco]]

Translating https://en.wikipedia.org/w/index.php?title=Catalan_language&oldid=1212864729 from English to Italian (or Catalan) removes whitespaces between some words.

E.g. It is the official language of Andorra becomes És la llengua oficial deAndorra.

Comment 1

[Greg Tatum [:gregtatum] (REO Fx132)]

There is a bug in the inline vs block logic. Here is a minimal STR:

      <p>
        This is some text.
        <span>It has inline elements</span>
        <style>/* And display none elements */</style>
      </p>

The style element is display: none, which is breaking the logic, and sending elements in as block elements rather than inline. This strips out the whitespace.

Comment 2

[Greg Tatum [:gregtatum] (REO Fx132)]

Attachment: Bug 1884722 - Fix the translations block subdividing for display none; r?#translations-reviewers!

Comment 3

[Greg Tatum [:gregtatum] (REO Fx132)]

The fix should improve translation quality as well, since it was sending each inline element in as a single sentence, rather than grouping it together.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe335b10fd54
Fix the translations block subdividing for display none; r=translations-reviewers,nordzilla

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fe335b10fd54