1884748 - Multiple images on the about:preferences#sync page are missing alt text

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Anna Yeddi [:ayeddi]]

Attachment: images_without_textual_alternative.png

There are multiple icons on the about:preferences#sync page that are missing any textual alternatives or are not marked up as decorative.

Examples include but are not limited to the following icons:

1. (!) attention in the about:policies container
2. fxaSyncIllustration
3. both the Android and iOS logo icons within the fxaMobilePromo container - could be resolved by moving the icons inside of their anchor elements
4. Unverified account: fxaProfileImage, fxaLoginRejectedWarning
5. logged in locally but server rejected credentials: fxaProfileImage, fxaLoginRejectedWarning

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: VoiceOver focuses the Android icon and announces it as just image.png

Refer to the WAI Alt Decision tree for different options to remediate the issue

Comment 2

[❌ PTO, back 5 Jan ❌ Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Should we triage this into the Sync component? Also, does anyone on the Sync team have capacity to take this bug? It's an access-s2.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1884748 - add alt text to images in about:preferences#sync. r?ayeddi

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Should we triage this into the Sync component?

I'm fine with that although that might not be great if you want it tracked as part of other l10n work.

I put a WIP up but I can't make it work (ie, most of the elements don't get the specified alt text) and need some help to proceed - who can I ask to help me out?

Comment 5

[❌ PTO, back 5 Jan ❌ Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

:markh note that you can request review from the settings-reviewers phabricator group

Comment 6

[Mark Hammond [:markh] [:mhammond]]

I put a WIP up but I can't make it work

With some help on slack I think I've got it working correctly - I requested review from :ayeddi on phab.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cdd02121732e
add alt text to images in about:preferences#sync. r=fluent-reviewers,flod,mconley,accessibility-frontend-reviewers,ayeddi

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/cdd02121732e