Closed Bug 1884812 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 45016 - Revert "Reapply "ReadableStream should be cancelled on aborting fetch streaming upload""

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox125 fixed)

Status:
RESOLVED FIXED
Milestone:
125 Branch
Tracking Flags:
Tracking Status
firefox125 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 45016 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45016
Details from upstream follow.

Yoichi Osato <yoichio@chromium.org> wrote:

Revert "Reapply "ReadableStream should be cancelled on aborting fetch streaming upload""

This reverts commit 9b6dfd300f3e867054f36c067d4db6d2f055e195.

Reason for revert: ci failure:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/119114/test-results?sortby=&groupby=

Original change's description:

Reapply "ReadableStream should be cancelled on aborting fetch streaming upload"

This reverts commit 80d8034488638d62c98d39f1e3b0d229f0f95948.

This CL reapplies the CL fixing the ci test failure:
https://ci.chromium.org/ui/p/chromium/builders/findit/test-single-revision/15511/overview
(see the diff from Patchset#1)

Fixed: 40071725
Change-Id: Iff847a32a5d5cc0da01343e97bc0f63eab4780cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5348005
Reviewed-by: Adam Rice \<ricea@chromium.org>
Commit-Queue: Adam Rice \<ricea@chromium.org>
Auto-Submit: Yoichi Osato \<yoichio@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1270046}

Bug: 40071725
Fixed: 328787040
Change-Id: I8a777dd4896fa95bf7e30346f285ec511c555617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5358674
Commit-Queue: Adam Rice \<ricea@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Adam Rice \<ricea@chromium.org>
Auto-Submit: Yoichi Osato \<yoichio@chromium.org>
Reviewed-by: Yoichi Osato \<yoichio@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1270818}

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 11 subtests

Status Summary

Firefox

OK : 3
PASS : 3
FAIL : 30
ERROR: 1

Chrome

OK : 4
PASS : 44

Safari

OK : 4
PASS : 4
FAIL : 40

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /fetch/api/basic/request-upload.h2.any.serviceworker.html [wpt.fyi]
    • Fetch with POST with empty ReadableStream: FAIL (Chrome: PASS, Safari: FAIL)
    • Fetch with POST with ReadableStream: FAIL (Chrome: PASS, Safari: FAIL)
    • Fetch with POST with ReadableStream on 421 response should return the response and not retry.: FAIL (Chrome: PASS, Safari: FAIL)
    • Feature detect for POST with ReadableStream: FAIL (Chrome: PASS, Safari: FAIL)
    • Feature detect for POST with ReadableStream, using request object: FAIL (Chrome: PASS, Safari: FAIL)
    • Synchronous feature detect: FAIL (Chrome: PASS, Safari: FAIL)
    • Streaming upload with body containing a String: FAIL (Chrome: PASS, Safari: FAIL)
    • Streaming upload with body containing null: FAIL (Chrome: PASS, Safari: FAIL)
    • Streaming upload with body containing a number: FAIL (Chrome: PASS, Safari: FAIL)
    • Streaming upload should fail on a 401 response: FAIL (Chrome: PASS, Safari: FAIL)
  • /fetch/api/basic/request-upload.h2.any.html [wpt.fyi]: ERROR (Chrome: OK, Safari: OK)
  • /fetch/api/basic/request-upload.h2.any.worker.html [wpt.fyi]
    • Fetch with POST with empty ReadableStream: FAIL (Chrome: PASS, Safari: FAIL)
    • Fetch with POST with ReadableStream: FAIL (Chrome: PASS, Safari: FAIL)
    • Fetch with POST with ReadableStream on 421 response should return the response and not retry.: FAIL (Chrome: PASS, Safari: FAIL)
    • Feature detect for POST with ReadableStream: FAIL (Chrome: PASS, Safari: FAIL)
    • Feature detect for POST with ReadableStream, using request object: FAIL (Chrome: PASS, Safari: FAIL)
    • Synchronous feature detect: FAIL (Chrome: PASS, Safari: FAIL)
    • Streaming upload with body containing a String: FAIL (Chrome: PASS, Safari: FAIL)
    • Streaming upload with body containing null: FAIL (Chrome: PASS, Safari: FAIL)
    • Streaming upload with body containing a number: FAIL (Chrome: PASS, Safari: FAIL)
    • Streaming upload should fail on a 401 response: FAIL (Chrome: PASS, Safari: FAIL)
  • /fetch/api/basic/request-upload.h2.any.sharedworker.html [wpt.fyi]
    • Fetch with POST with empty ReadableStream: FAIL (Chrome: PASS, Safari: FAIL)
    • Fetch with POST with ReadableStream: FAIL (Chrome: PASS, Safari: FAIL)
    • Fetch with POST with ReadableStream on 421 response should return the response and not retry.: FAIL (Chrome: PASS, Safari: FAIL)
    • Feature detect for POST with ReadableStream: FAIL (Chrome: PASS, Safari: FAIL)
    • Feature detect for POST with ReadableStream, using request object: FAIL (Chrome: PASS, Safari: FAIL)
    • Synchronous feature detect: FAIL (Chrome: PASS, Safari: FAIL)
    • Streaming upload with body containing a String: FAIL (Chrome: PASS, Safari: FAIL)
    • Streaming upload with body containing null: FAIL (Chrome: PASS, Safari: FAIL)
    • Streaming upload with body containing a number: FAIL (Chrome: PASS, Safari: FAIL)
    • Streaming upload should fail on a 401 response: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/228e538013ab [wpt PR 45016] - Revert "Reapply "ReadableStream should be cancelled on aborting fetch streaming upload"", a=testonly

https://hg.mozilla.org/mozilla-central/rev/228e538013ab

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox125: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in before you can comment on or make changes to this bug.