1884875 - [wpt-sync] Sync PR 44931 - [css-scroll-snap-2] Fix targeted snap point selection

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44931 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44931
Details from upstream follow.

David Awogbemila <[e-mail]> wrote:

[css-scroll-snap-2] Fix targeted snap point selection

For a page's main frame, Document::SetCSSTarget is called too late to
let the snap containers know which areas to consider targeted. (So, we
need to queue these snap containers up for an update).
For iframes, it is early enough, which is why the tests that were added
to verify snap point selection with targeted elements pass.

This patch adds a new test, prefer-targeted-element-main-frame.html,
which tests snap point selection with a targeted element without iframes
by opening a new window with a hash fragment and reading the result of
the test in that window via fetch.

Bug: 324916797
Change-Id: If2f1d0e27368587d5207dc11540fe705d4ab2d36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5345331
Reviewed-by: Steve Kobes \<[e-mail]>
Commit-Queue: David Awogbemila \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1271352}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c558777a2db0f358dc1c8f3b69497f01ec98aba

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 9 subtests

Status Summary

Firefox

OK : 1
FAIL : 9[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 18[GitHub]
TIMEOUT: 1
ERROR : 1
NOTRUN : 8

Chrome

OK : 2
PASS : 13
FAIL : 5

Safari

OK : 1
FAIL : 18
ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-scroll-snap/snap-after-relayout/multiple-aligned-targets/prefer-targeted-element-main-frame.html [wpt.fyi]
  • targeted box1 is selected snap target.: FAIL (Chrome: PASS, Safari: FAIL)
  • targeted box2 is selected snap target.: FAIL (Chrome: FAIL, Safari: FAIL)
  • targeted box3 is selected snap target.: FAIL (Chrome: FAIL, Safari: FAIL)
  • targeted box4 is selected snap target.: FAIL (Chrome: PASS, Safari: FAIL)
  • targeted box5 is selected snap target.: FAIL (Chrome: PASS, Safari: FAIL)
  • targeted box6 is selected snap target.: FAIL (Chrome: FAIL, Safari: FAIL)
  • targeted box7 is selected snap target.: FAIL (Chrome: FAIL, Safari: FAIL)
  • targeted box8 is selected snap target.: FAIL (Chrome: FAIL, Safari: FAIL)
  • targeted box9 is selected snap target.: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-scroll-snap/snap-after-relayout/multiple-aligned-targets/prefer-targeted-element.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
  • scroller selects targeted area box1 among multiple aligned areas.: FAIL [GitHub], TIMEOUT [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • scroller selects targeted area box2 among multiple aligned areas.: FAIL [GitHub], NOTRUN [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • scroller selects targeted area box3 among multiple aligned areas.: FAIL [GitHub], NOTRUN [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • scroller selects targeted area box4 among multiple aligned areas.: FAIL [GitHub], NOTRUN [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • scroller selects targeted area box5 among multiple aligned areas.: FAIL [GitHub], NOTRUN [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • scroller selects targeted area box6 among multiple aligned areas.: FAIL [GitHub], NOTRUN [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • scroller selects targeted area box7 among multiple aligned areas.: FAIL [GitHub], NOTRUN [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • scroller selects targeted area box8 among multiple aligned areas.: FAIL [GitHub], NOTRUN [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)
  • scroller selects targeted area box9 among multiple aligned areas.: FAIL [GitHub], NOTRUN [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5d95acd6bd2
[wpt PR 44931] - [css-scroll-snap-2] Fix targeted snap point selection, a=testonly
https://hg.mozilla.org/integration/autoland/rev/d95f02751b35
[wpt PR 44931] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e5d95acd6bd2
https://hg.mozilla.org/mozilla-central/rev/d95f02751b35