1884879 - New wpt failures in /css/ [css-nesting/parsing.html, css-syntax/custom-property-rule-ambiguity.html]

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 45020 found new untriaged test failures in CI

Tests Affected

New Tests That Don't Pass

• /css/css-nesting/parsing.html [wpt.fyi]
  • .foo { .foo, .bar { color: green; }}: FAIL (Chrome: FAIL, Safari: PASS)
• /css/css-syntax/custom-property-rule-ambiguity.html [wpt.fyi]
  • Rule that looks like a custom property declaration is ignored: FAIL (Chrome: PASS, Safari: FAIL)
  • Rule that looks like an invalid custom property declaration is ignored: FAIL (Chrome: PASS, Safari: FAIL)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1884826 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1884879 - [css-syntax] Implement recent syntax spec change to avoid parsing custom properties that look like selectors. r=#style,#layout

This implements the:

If the first two non-<whitespace-token> values of rule’s prelude are
an <ident-token> whose value starts with "--" followed by a
<colon-token>, then...

From https://drafts.csswg.org/css-syntax/#consume-qualified-rule

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1884879 - [css-syntax] [css-nesting] Implement recent spec change about blocks and custom / non-custom properties. r=#style,#layout

From https://github.com/w3c/csswg-drafts/issues/9317

Do some gymnastics to avoid rewinding unnecessarily, since this is
super-hot code.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbad005d70dc
[css-syntax] Implement recent syntax spec change to avoid parsing custom properties that look like selectors. r=firefox-style-system-reviewers,zrhoffman,supply-chain-reviewers,glandium
https://hg.mozilla.org/integration/autoland/rev/0c04b1ea36b9
[css-syntax] [css-nesting] Implement recent spec change about blocks and custom / non-custom properties. r=firefox-style-system-reviewers,zrhoffman

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45999 for changes under testing/web-platform/tests

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/cbad005d70dc
https://hg.mozilla.org/mozilla-central/rev/0c04b1ea36b9

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot