1884922 - [wpt-sync] Sync PR 45055 - Reland "Implement constructor in RTCEncodedVideoFrame"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 45055 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/45055
Details from upstream follow.

Palak Agarwal <[e-mail]> wrote:

Reland "Implement constructor in RTCEncodedVideoFrame"

This is a reland of commit edd81f4f02dd5ebb365f0e7eceb42780a881920f

Reason for reland: The CL was reverted because of https://issues.chromium.org/issues/328306658, which now has been fixed.

Original change's description:

Implement constructor in RTCEncodedVideoFrame

This is inline with the algorithm described in https://github.com/w3c/webrtc-encoded-transform/compare/main...palak8669:webrtc-encoded-transform:constructor_frame

This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/5295578 which got reverted due
to wrong include rules.

Bug: 14709
Change-Id: I5da20d10295908b2592c3c7202aa56fd206bf908
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5307134
Reviewed-by: Guido Urdaneta \<[e-mail]>
Commit-Queue: Palak Agarwal \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1268408}

Bug: 14709
Change-Id: I8e827e7df8fee676e85580b5f6e1044fa06ea6a9

Reviewed-on: https://chromium-review.googlesource.com/5366041
WPT-Export-Revision: 109bf1db6dab5d397828570ee2d86a76300f62a8

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=65f8e6b2018ae5a27c6809ea015ee06bf7f1df0a

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
FAIL: 4

Chrome

OK : 1
PASS: 1
FAIL: 3

Safari

OK : 1
FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webrtc-encoded-transform/tentative/RTCEncodedVideoFrame-metadata.https.html [wpt.fyi]
  • [VP8] setMetadata() carries over codec-specific properties: FAIL (Chrome: PASS, Safari: FAIL)
  • [VP8] constructor carries over codec-specific properties: FAIL (Chrome: FAIL, Safari: FAIL)
  • [VP8] constructor with metadata carries over codec-specific properties: FAIL (Chrome: FAIL, Safari: FAIL)
  • [VP8] constructor without metadata does not carry over modified metadata : FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1db52fdddf67
[wpt PR 45055] - Reland "Implement constructor in RTCEncodedVideoFrame", a=testonly
https://hg.mozilla.org/integration/autoland/rev/9a3a0b5d8fb8
[wpt PR 45055] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1db52fdddf67
https://hg.mozilla.org/mozilla-central/rev/9a3a0b5d8fb8