1884931 - (SQLite3.45.2) Upgrade to SQLite 3.45.2

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, task)

Description

[Ryan VanderMeulen [:RyanVM]]

+++ This bug was initially created as a clone of Bug #1858473 +++

Changes in version 3.45.2 (2024-03-12):

• Fix an error in UPSERT, introduced by enhancement 3a in version 3.35.0 (2021-03-12), that could cause an index to get out-of-sync with its table. Forum thread 919c6579c8.
• Reduce the scope of the NOT NULL strength reduction optimization that was added as item 8e in version 3.35.0 (2021-03-12). The optimization was being attempted in some contexts where it did not work, resulting in incorrect query results. Forum thread 440f2a2f17.
• Other trifling corrections and compiler warning fixes that have come up since the previous patch release. See the timeline for details.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1884931 - Upgrade to SQLite 3.45.2. r=mak

Comment 2

[Marco Bonardo [:mak]]

I don't see a fix for Bug 1878311 in the timeline, unless it's hidden in some other checkin.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

I didn't set a dependency because I didn't either. I can still run a Try push later to confirm.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49e9b26b528b
Upgrade to SQLite 3.45.2. r=mak

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/49e9b26b528b

Comment 6

[Arthur K. (he/him)]

3.45.3 got released a couple days ago.

Changes in this specific patch release, version 3.45.3 (2024-04-15):

• Fix a long-standing bug (going back to version 3.24.0) that might (rarely) cause the "old.*" values of an UPDATE trigger to be incorrect if that trigger fires in response to an UPSERT. Forum post 284955a3cd454a15.
• Fix a bug in sum() that could cause it to return NULL when it should return Infinity. Forum post 23b8688ef4.
• Other trifling corrections and compiler warning fixes that have come up since the previous patch release. See the timeline for details.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

We're aware. We decided to skip it as there was nothing of importance to Firefox in it.