Revisit CaR build flags for Android
Categories
(Testing :: Performance, task, P3)
Tracking
(Not tracked)
People
(Reporter: kshampur, Unassigned)
References
Details
(Whiteboard: [fxp])
in particular, these flags
https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/taskcluster/ci/toolchain/misc.yml#287,294,297,302-303
- component build may affect start up time
- symbol stuff for debugging/traces (though we don't currently run trace on android, so may not be important)
- v8 context may affect pageload (so was not a big deal for benchmark)
We maybe should focus on this for Android first before doing the same for Desktop (and on Desktop, we should prioritize Win64 >= OSX Arm64 > OSX x64 > linux)
|
||
Updated•1 year ago
|
|
Reporter | |
Comment 1•1 year ago
|
||
For clarity, the current settings are the way that they are in order to speed up build times e.g. https://chromium.googlesource.com/chromium/src/+/main/docs/linux/build_instructions.md#faster-builds & https://chromium.googlesource.com/chromium/src/+/main/docs/android_build_instructions.md#faster-builds
|
|
Reporter | |
Comment 2•1 year ago
|
||
as discussed in meeting, I am going to toggle these flags and see how they affect the builds (in particular, failures or how much build times increase)
|
|
Reporter | |
Comment 3•1 year ago
|
||
Run with current flags for reference, 211 minutes
v8 context snapshot enabled 305 minutes
(compare of sp3 with base)
symbols level 1 + v8 context snapshot enabled 309 minutes
(compare of sp3 with base)
fortunately adding the flags don't seem to cause failures
the v8 context flag adds to the build time by quite a bit (~1.5 hrs) but the symbols don't really. However these are level 1 symbols, some of these have a level 2 (actually, maybe just symbol_level has a level 2 option available). I haven't checked that, but expect maybe a bit more increase in build time with this flag set to level 2.
Ignore one of the flags i mention in comment 0, (component build) It seems that is not possible to set to true and be official builds e.g.
We have no android CaR pageload tests at the moment so I can't check that, but use_v8_context_snapshot should affect (improve) pageloads so it is good we can build it on Android CaR. It is worth noting that this flag may cause intermittent failures (I have seen it happen a lot on desktop builds in the past, and that is part of the reason it was disabled before. The other reason is it drastically reduced OSX cross compilation).
Description
•