1884985 - Intermittent SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/layout/style/FontFaceImpl.cpp:679:20 in AddFontFaceSet | single tracking bug

Status: RESOLVED DUPLICATE of bug 1878199

(Core :: Layout: Text and Fonts, defect)

Description

Filed by: sstanca [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=450484490&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Xiyd_NDwSdGdboXqfWMcEw/runs/0/artifacts/public/logs/live_backing.log

---

task 2024-03-12T16:44:15.718Z] 16:44:15     INFO - TEST-OK | /html/canvas/offscreen/text/2d.text.measure.emHeights-zero-descent.html | took 1106ms
[task 2024-03-12T16:44:15.719Z] 16:44:15     INFO - TEST-START | /html/canvas/offscreen/text/2d.text.measure.emHeights-zero-descent.worker.html
[task 2024-03-12T16:44:15.745Z] 16:44:15     INFO - Closing window 6b04005b-eee1-4160-be51-3110c00925fd
[task 2024-03-12T16:44:17.642Z] 16:44:17     INFO - PID 984 | ==================
[task 2024-03-12T16:44:17.643Z] 16:44:17     INFO - PID 984 | WARNING: ThreadSanitizer: data race (pid=1194)
[task 2024-03-12T16:44:17.643Z] 16:44:17     INFO - PID 984 |   Write of size 1 at 0x7b18000ff1d1 by thread T1010 (mutexes: write M0):
[task 2024-03-12T16:44:17.644Z] 16:44:17     INFO - PID 984 |     #0 AddFontFaceSet /builds/worker/checkouts/gecko/layout/style/FontFaceImpl.cpp:679:20 (libxul.so+0x8002924) (BuildId: d5ac79dd4a280fe355dc15e977778fca3cae0b9e)
[task 2024-03-12T16:44:17.645Z] 16:44:17     INFO - PID 984 |     #1 mozilla::dom::FontFaceSetImpl::Add(mozilla::dom::FontFaceImpl*, mozilla::ErrorResult&) /builds/worker/checkouts/gecko/layout/style/FontFaceSetImpl.cpp:270:14 (libxul.so+0x8002924)
[task 2024-03-12T16:44:17.645Z] 16:44:17     INFO - PID 984 |     #2 mozilla::dom::FontFaceSet::Add(mozilla::dom::FontFace&, mozilla::ErrorResult&) /builds/worker/checkouts/gecko/layout/style/FontFaceSet.cpp:227:15 (libxul.so+0x7ffe421) (BuildId: d5ac79dd4a280fe355dc15e977778fca3cae0b9e)
[task 2024-03-12T16:44:17.646Z] 16:44:17     INFO - PID 984 |     #3 mozilla::dom::FontFaceSet_Binding::add(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) /builds/worker/workspace/obj-build/dom/bindings/./FontFaceSetBinding.cpp:262:22 (libxul.so+0x5a57697) (BuildId: d5ac79dd4a280fe355dc15e977778fca3cae0b9e)
[task 2024-03-12T16:44:17.647Z] 16:44:17     INFO - PID 984 |     #4 bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) /builds/worker/checkouts/gecko/dom/bindings/BindingUtils.cpp:3258:13 (libxul.so+0x5c0fca9) (BuildId: d5ac79dd4a280fe355dc15e977778fca3cae0b9e)
[task 2024-03-12T16:44:17.648Z] 16:44:17     INFO - PID 984 |     #5 CallJSNative /builds/worker/checkouts/gecko/js/src/vm/Interpreter.cpp:479:13 (libxul.so+0x9db74b9) (BuildId: d5ac79dd4a280fe355dc15e977778fca3cae0b9e)
<...>
[task 2024-03-12T16:44:17.683Z] 16:44:17     INFO - PID 984 |   Previous read of size 1 at 0x7b18000ff1d1 by main thread (mutexes: write M1):
[task 2024-03-12T16:44:17.684Z] 16:44:17     INFO - PID 984 |     #0 mozilla::dom::FontFaceImpl::Entry::GetUserFontSets(nsTArray<RefPtr<gfxUserFontSet>>&) /builds/worker/checkouts/gecko/layout/style/FontFaceImpl.cpp:770:12 (libxul.so+0x7ffbfb6) (BuildId: d5ac79dd4a280fe355dc15e977778fca3cae0b9e)
[task 2024-03-12T16:44:17.685Z] 16:44:17     INFO - PID 984 |     #1 gfxUserFontEntry::IncrementGeneration() /builds/worker/checkouts/gecko/gfx/thebes/gfxUserFontSet.cpp:841:3 (libxul.so+0x465ac08) (BuildId: d5ac79dd4a280fe355dc15e977778fca3cae0b9e)
[task 2024-03-12T16:44:17.686Z] 16:44:17     INFO - PID 984 |     #2 gfxUserFontEntry::ContinueLoad() /builds/worker/checkouts/gecko/gfx/thebes/gfxUserFontSet.cpp:415:5 (libxul.so+0x465aba0) (BuildId: d5ac79dd4a280fe355dc15e977778fca3cae0b9e)
[task 2024-03-12T16:44:17.687Z] 16:44:17     INFO - PID 984 |     #3 operator()<> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1085:18 (libxul.so+0x466d929) (BuildId: d5ac79dd4a280fe355dc15e977778fca3cae0b9e)
[task 2024-03-12T16:44:17.687Z] 16:44:17     INFO - PID 984 |     #4 __invoke_impl<void, (lambda at /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1084:9)> /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/invoke.h:60:14 (libxul.so+0x466d929)
[task 2024-03-12T16:44:17.688Z] 16:44:17     INFO - PID 984 |     #5 __invoke<(lambda at /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1084:9)> /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/bits/invoke.h:95:14 (libxul.so+0x466d929)
[task 2024-03-12T16:44:17.689Z] 16:44:17     INFO - PID 984 |     #6 __apply_impl<(lambda at /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1084:9), std::tuple<> &> /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/tuple:1678:14 (libxul.so+0x466d929)
[task 2024-03-12T16:44:17.689Z] 16:44:17     INFO - PID 984 |     #7 apply<(lambda at /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1084:9), std::tuple<> &> /builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/lib/gcc/x86_64-linux-gnu/8/../../../../include/c++/8/tuple:1687:14 (libxul.so+0x466d929)
[task 2024-03-12T16:44:17.690Z] 16:44:17     INFO - PID 984 |     #8 apply<gfxUserFontEntry, void (gfxUserFontEntry::*)()> /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1083:12 (libxul.so+0x466d929)
[task 2024-03-12T16:44:17.691Z] 16:44:17     INFO - PID 984 |     #9 mozilla::detail::RunnableMethodImpl<gfxUserFontEntry*, void (gfxUserFontEntry::*)(), true, (mozilla::RunnableKind)0>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:1134:13 (libxul.so+0x466d929)
[task 2024-03-12T16:44:17.691Z] 16:44:17     INFO - PID 984 |     #10 mozilla::RunnableTask::Run() /builds/worker/checkouts/gecko/xpcom/threads/TaskController.cpp:578:16 (libxul.so+0x31e1e62) (BuildId: d5ac79dd4a280fe355dc15e977778fca3cae0b9e)
<...>
[task 2024-03-12T16:44:17.709Z] 16:44:17     INFO - PID 984 |   Location is heap block of size 88 at 0x7b18000ff180 allocated by thread T1010:
[task 2024-03-12T16:44:17.709Z] 16:44:17     INFO - PID 984 |     #0 malloc /builds/worker/fetches/llvm-project/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:663:5 (firefox-bin+0xc3e2c) (BuildId: e38fcab30d824588ddfd9589d5e8ae4eea5b7cb2)
[task 2024-03-12T16:44:17.710Z] 16:44:17     INFO - PID 984 |     #1 moz_xmalloc /builds/worker/checkouts/gecko/memory/mozalloc/mozalloc.cpp:52:15 (firefox-bin+0x150a58) (BuildId: e38fcab30d824588ddfd9589d5e8ae4eea5b7cb2)
[task 2024-03-12T16:44:17.711Z] 16:44:17     INFO - PID 984 |     #2 operator new /builds/worker/workspace/obj-build/dist/include/mozilla/cxxalloc.h:33:10 (libxul.so+0x7ff72a2) (BuildId: d5ac79dd4a280fe355dc15e977778fca3cae0b9e)
[task 2024-03-12T16:44:17.712Z] 16:44:17     INFO - PID 984 |     #3 mozilla::dom::FontFace::Constructor(mozilla::dom::GlobalObject const&, nsTSubstring<char> const&, mozilla::dom::UTF8StringOrArrayBufferOrArrayBufferView const&, mozilla::dom::FontFaceDescriptors const&, mozilla::ErrorResult&) /builds/worker/checkouts/gecko/layout/style/FontFace.cpp:122:16 (libxul.so+0x7ff72a2)
[task 2024-03-12T16:44:17.712Z] 16:44:17     INFO - PID 984 |     #4 mozilla::dom::FontFace_Binding::_constructor(JSContext*, unsigned int, JS::Value*) /builds/worker/workspace/obj-build/dom/bindings/./FontFaceBinding.cpp:2199:52 (libxul.so+0x5a526f6) (BuildId: d5ac79dd4a280fe355dc15e977778fca3cae0b9e)
<...>
[task 2024-03-12T16:44:17.780Z] 16:44:17     INFO - PID 984 |   Mutex M0 (0x7b40000f1460) created at:
[task 2024-03-12T16:44:17.781Z] 16:44:17     INFO - PID 984 |     #0 pthread_mutex_init /builds/worker/fetches/llvm-project/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:1313:3 (firefox-bin+0xc73f0) (BuildId: e38fcab30d824588ddfd9589d5e8ae4eea5b7cb2)
[task 2024-03-12T16:44:17.782Z] 16:44:17     INFO - PID 984 |     #1 mozilla::RecursiveMutex::RecursiveMutex(char const*) /builds/worker/checkouts/gecko/xpcom/threads/RecursiveMutex.cpp:50:3 (libxul.so+0x31d168d) (BuildId: d5ac79dd4a280fe355dc15e977778fca3cae0b9e)
[task 2024-03-12T16:44:17.782Z] 16:44:17     INFO - PID 984 |     #2 mozilla::dom::FontFaceSetImpl::FontFaceSetImpl(mozilla::dom::FontFaceSet*) /builds/worker/checkouts/gecko/layout/style/FontFaceSetImpl.cpp:73:7 (libxul.so+0x800108d) (BuildId: d5ac79dd4a280fe355dc15e977778fca3cae0b9e)
<...>
[task 2024-03-12T16:44:17.829Z] 16:44:17     INFO - PID 984 |   Mutex M1 (0x7b54001dd518) created at:
<...>
[task 2024-03-12T16:44:17.832Z] 16:44:17     INFO - PID 984 |     #4 Entry /builds/worker/workspace/obj-build/dist/include/mozilla/dom/FontFaceImpl.h:53:11 (libxul.so+0x8008756)
[task 2024-03-12T16:44:17.833Z] 16:44:17     INFO - PID 984 |     #5 CreateUserFontEntry /builds/worker/checkouts/gecko/layout/style/FontFaceSetImpl.cpp:925:40 (libxul.so+0x8008756)
[task 2024-03-12T16:44:17.833Z] 16:44:17     INFO - PID 984 |     #6 non-virtual thunk to mozilla::dom::FontFaceSetImpl::CreateUserFontEntry(nsTArray<gfxFontFaceSrc>&&, gfxUserFontAttributes&&) /builds/worker/checkouts/gecko/layout/style/FontFaceSetImpl.cpp (libxul.so+0x8008756)
<...>
task 2024-03-12T16:44:17.876Z] 16:44:17     INFO - PID 984 |   Thread T1010 'DOM Worker' (tid=9904, running) created by main thread at:
<...>
[task 2024-03-12T16:44:17.923Z] 16:44:17     INFO - PID 984 | SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/layout/style/FontFaceImpl.cpp:679:20 in AddFontFaceSet
<...>
[task 2024-03-12T16:44:18.612Z] 16:44:18     INFO - TEST-UNEXPECTED-CRASH | /html/canvas/offscreen/text/2d.text.measure.emHeights-zero-descent.worker.html | expected OK

Comment 1

[Andrew McCreight [:mccr8]]

This looks like layout font stuff, so I'll move it there. I also tried to edit the stacks a bit in comment 0 so they have more useful info.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Dupe of bug 1878199 from what I can see.